tests: Adds [LinuxOnly] tag to conformance test#73922
tests: Adds [LinuxOnly] tag to conformance test#73922k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
The test "should write entries to /etc/hosts" should have the [LinuxOnly] tag as it cannot pass on Windows; individual files cannot be mounted in Windows Containers. This test was missed in the original PR (kubernetes#73204)
|
Hi @BCLAU. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/area conformance @BCLAU please consider applying for membership to the kubernetes github org :) |
|
@yujuhong @Random-Liu Does this look good to you? /sig node |
|
/lgtm |
|
/cc @PatrickLang |
|
/lgtm |
|
/assign @pwittrock |
|
/priority important-soon |
|
Shouldn't HostAliases work on Windows? The logic here isn't clear to me also - I see the justification as "individual files cannot be mounted in Windows Containers" yet I don't see any files being mounted. My understanding is that /etc/hosts is typically copied into the containers on linux, not mounted. |
hm, i don't know what was decided for GA. possibly the comment for the related issue: |
|
Good links, thanks @neolit123! AFAIK HostAliases isn't critical enough that it should be a blocker for windows support, but I do think we should be excruciatingly precise about why we are excluding it, as it is a conformance test. |
No, the Although, copying the hosts file into the container could be a viable alternative. However, that is outside the scope of this PR or the target for this release. This can be further discussed for v1.15. PS: updated test description to include a more detailed explanation. |
11c62a6 to
4340903
Compare
neolit123
left a comment
There was a problem hiding this comment.
/lgtm
thanks for the comment update.
|
re: single file mapping This is something that's possible in Windows Server 2019, but not with the Docker codebase. It has been implemented in containerd, but containerd is not stable enough to take it for 1.14. Rather than implementing a workaround of replacing a file after the pod starts, I think it would be best to do the right fix and support |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bclau, spiffxp, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What type of PR is this?
/kind failing-test
/sig testing
/sig windows
What this PR does / why we need it:
The test "should write entries to /etc/hosts" should have the [LinuxOnly] tag as
it cannot pass on Windows; individual files cannot be mounted in Windows Containers.
This test was missed in the original PR (#73204)
Which issue(s) this PR fixes:
Related Issue: #69871
Special notes for your reviewer:
Does this PR introduce a user-facing change?: