Skip to content

Experimental: publish CRD openapi schema quickly#72979

Closed
roycaihw wants to merge 2 commits intokubernetes:masterfrom
roycaihw:crd-publish-openapi-quick
Closed

Experimental: publish CRD openapi schema quickly#72979
roycaihw wants to merge 2 commits intokubernetes:masterfrom
roycaihw:crd-publish-openapi-quick

Conversation

@roycaihw
Copy link
Copy Markdown
Member

@roycaihw roycaihw commented Jan 16, 2019

What this PR does / why we need it:
This PR has same goal as #71192, but puts crd_openapi_controller in aggregator-apiserver instead of apiextensions-apiserver, to avoid the one-minute latency in openapi propagation between apiextensions-apiserver and aggregator-apiserver.

Which issue(s) this PR fixes:

Fixes #71143

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 16, 2019

@roycaihw: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 16, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: roycaihw
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: deads2k

If they are not already assigned, you can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roycaihw roycaihw force-pushed the crd-publish-openapi-quick branch from 4353858 to 0e49175 Compare January 16, 2019 19:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 16, 2019 •
edited
Loading

@roycaihw: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 0e49175 link /test pull-kubernetes-integration
pull-kubernetes-godeps 0e49175 link /test pull-kubernetes-godeps
pull-kubernetes-verify 0e49175 link /test pull-kubernetes-verify
pull-kubernetes-e2e-gce 0e49175 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@roycaihw roycaihw mentioned this pull request Jan 17, 2019
Merged
3 tasks
@roycaihw roycaihw closed this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@janetkuo janetkuo Awaiting requested review from janetkuo

Assignees

No one assigned

Labels

area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Published CRD openapi schema takes ~60 seconds to appear, increased test time significantly

2 participants

@roycaihw @k8s-ci-robot