Windows networking tests by claudiubelu · Pull Request #71468 · kubernetes/kubernetes

claudiubelu · 2018-11-27T16:52:47Z

What type of PR is this?

/kind feature

/sig testing
/sig windows

What this PR does / why we need it:

Some Conformance tests are not able to pass on Windows due to how some things are not supported on Windows, or they work differently from Linux:

Pods with HostNetwork are not currently supported on Windows. This PR adds the equivalent Windows tests inside the test/e2e/windows folder.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related: #69871

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2018-11-27T16:52:55Z

Hi @BCLAU. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

daschott · 2018-11-27T18:34:58Z

@BCLAU @dineshgovindasamy @nagiesek can we also include the DNS PR here? #70156

claudiubelu · 2018-11-28T14:36:51Z

@daschott Done.

PatrickLang · 2018-12-04T17:08:58Z

@spiffxp @dchen1107 - can either of you help review or approve? These are some copies of tests modified to run on Windows. We need to get these merged and running so we can cover this functionality on the windows testgrid job instead of excluding it because they depend on Linux behaviors.

gnufied · 2018-12-04T17:23:39Z

/unassign

spiffxp

/ok-to-test

I'm a little concerned with how we're going to keep track of which tests are copy/forked into sig-windows temporarily, which must live there forever because we can't workaround something fundamental, and which must live there because they are supplemental for windows.

I also feel like these should be explaining why they need to differ, which could be helpful in documenting expected behavior on windows.

test/e2e/framework/util.go

spiffxp · 2018-12-05T02:08:09Z

test/e2e/network/dns.go

/cc @thockin @kubernetes/cncf-conformance-wg @kubernetes/sig-architecture-pr-reviews
I'm getting similar feels as #70156 (comment) about dropping PQDN resolution from conformance, I lack as much context on where that discussion has gone. Are we OK with this?

test/e2e/framework/networking_utils.go

spiffxp · 2018-12-05T02:45:55Z

test/e2e/network/dns.go

if we are ok splitting up DNS into conformance/extra test cases, can we refactor to de-dupe the actual test mechanics?

test/e2e/windows/runtime.go

claudiubelu · 2019-01-21T11:10:51Z

@bgrant0607 Done

claudiubelu · 2019-01-24T12:05:28Z

/test pull-kubernetes-e2e-kops-aws

Creating pods with HostNetwork is not currently supported on Windows Kubelet, and thus, ones without HostNetwork are created instead.

PatrickLang · 2019-02-07T22:37:55Z

@BCLAU - can you retitle this to "Windows networking & DNS conformance test updates" ?

claudiubelu · 2019-02-12T13:28:12Z

/retest

claudiubelu · 2019-02-12T14:44:54Z

/test pull-kubernetes-verify

claudiubelu · 2019-02-12T17:45:58Z

/test pull-kubernetes-verify

claudiubelu · 2019-02-14T16:45:09Z

/test pull-kubernetes-verify

ixdy · 2019-02-16T00:46:21Z

/lgtm
/approve

smarterclayton · 2019-02-16T01:38:34Z

Conformance changes must not be in the same PR as the test enablement. Please split this into the core test changes, then the one that changes the conformance title.

claudiubelu · 2019-02-18T12:50:23Z

Conformance changes must not be in the same PR as the test enablement. Please split this into the core test changes, then the one that changes the conformance title.

@smarterclayton @ixdy So, the 2nd commit in the PR (the one regarding the DNS conformance change) already has a separate PR for it, so please /approve and /lgtm it if it looks good to you. I will remove that commit from this PR then.

k8s-ci-robot · 2019-02-18T12:52:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bclau, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [ixdy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

smarterclayton · 2019-02-18T14:22:14Z

/lgtm

k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 27, 2018

k8s-ci-robot requested review from gnufied and ncdc November 27, 2018 16:53

claudiubelu force-pushed the windows-tests branch from 1fb4b12 to 9b5993e Compare November 28, 2018 14:35

claudiubelu force-pushed the windows-tests branch 2 times, most recently from 9259be5 to 6271020 Compare November 30, 2018 13:12

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2018

spiffxp reviewed Dec 5, 2018

View reviewed changes

k8s-ci-robot requested a review from thockin December 5, 2018 02:52

k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Dec 5, 2018

claudiubelu force-pushed the windows-tests branch 2 times, most recently from 9ad3da2 to a61b26d Compare January 23, 2019 11:18

claudiubelu mentioned this pull request Jan 24, 2019

Adds [LinuxOnly] tag to conformance tests that cannot be run on Windows #73204

Merged

claudiubelu force-pushed the windows-tests branch from a61b26d to a35e966 Compare February 5, 2019 15:59

Adds Windows-related Networking tests

00e2582

Creating pods with HostNetwork is not currently supported on Windows Kubelet, and thus, ones without HostNetwork are created instead.

claudiubelu force-pushed the windows-tests branch from a35e966 to 7ef9853 Compare February 12, 2019 12:49

claudiubelu changed the title ~~Windows tests~~ Windows networking & DNS conformance test updates Feb 12, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2019

claudiubelu force-pushed the windows-tests branch from d3f003b to 00e2582 Compare February 18, 2019 12:51

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2019

claudiubelu changed the title ~~Windows networking & DNS conformance test updates~~ Windows networking tests Feb 18, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2019

k8s-ci-robot merged commit f7eb576 into kubernetes:master Feb 18, 2019

claudiubelu mentioned this pull request Feb 20, 2019

REQUEST: New membership for bclau kubernetes/org#509

Closed

6 tasks

claudiubelu mentioned this pull request Mar 5, 2019

Sets HostNetwork to False for tests which do not require it #69525

Closed

claudiubelu deleted the windows-tests branch April 19, 2019 13:38

johnbelamaric mentioned this pull request Nov 8, 2019

Sets HostNetwork to False for tests which do not require it #78731

Merged

Conversation

claudiubelu commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Nov 27, 2018

Uh oh!

daschott commented Nov 27, 2018

Uh oh!

claudiubelu commented Nov 28, 2018

Uh oh!

PatrickLang commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gnufied commented Dec 4, 2018

Uh oh!

spiffxp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spiffxp Dec 5, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spiffxp Dec 5, 2018

Choose a reason for hiding this comment

Uh oh!

nagiesek Dec 5, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

claudiubelu commented Jan 21, 2019

Uh oh!

claudiubelu commented Jan 24, 2019

Uh oh!

PatrickLang commented Feb 7, 2019

Uh oh!

claudiubelu commented Feb 12, 2019

Uh oh!

claudiubelu commented Feb 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claudiubelu commented Feb 12, 2019

Uh oh!

claudiubelu commented Feb 14, 2019

Uh oh!

ixdy commented Feb 16, 2019

Uh oh!

smarterclayton commented Feb 16, 2019

Uh oh!

claudiubelu commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 18, 2019

Uh oh!

smarterclayton commented Feb 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

claudiubelu commented Nov 27, 2018 •

edited

Loading

PatrickLang commented Dec 4, 2018 •

edited

Loading

claudiubelu commented Feb 12, 2019 •

edited

Loading

claudiubelu commented Feb 18, 2019 •

edited

Loading