Skip to content

Revert openapi publish#71158

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
liggitt:revert-openapi-publish
Nov 17, 2018
Merged

Revert openapi publish#71158
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
liggitt:revert-openapi-publish

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Nov 16, 2018 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Several issues were found post-merge in #67205:

Reverting for freeze, will work on resolving those issues out of master

NONE

/assign sttts roycaihw

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 16, 2018
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Nov 16, 2018

Lgtm, after rebase.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 16, 2018 •
edited
Loading

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 6619d414a1c64c64fd1fa5d58989c984f4cec990 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Revert "Merge pull request kubernetes#71137 from sttts/sttts-crd-open…
ad2b916 
…api-spec-recursive-v2-prune"

This reverts commit 3ea3cfc, reversing
changes made to fab7009.
@liggitt
Revert "Merge pull request kubernetes#67205 from roycaihw/crd-openapi…
8799eb4 
…-spec"

This reverts commit 54ee58b, reversing
changes made to 9e2820e.
@liggitt liggitt force-pushed the revert-openapi-publish branch from 6619d41 to 8799eb4 Compare November 16, 2018 21:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2018
@dims
Copy link
Copy Markdown
Member

dims commented Nov 16, 2018

ouch!

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Nov 16, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@roycaihw
Copy link
Copy Markdown
Member

roycaihw commented Nov 16, 2018

/lgtm

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 16, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 16, 2018
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 16, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 16, 2018
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 16, 2018

/assign @smarterclayton
for approval

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Nov 16, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2018
dougm
dougm reviewed Nov 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watching for inclusion in 1.13.0-beta.1

@cjwagner
Copy link
Copy Markdown
Member

cjwagner commented Nov 17, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 39c8219 into kubernetes:master Nov 17, 2018
@roycaihw roycaihw mentioned this pull request Nov 18, 2018
Merged
@roycaihw
Copy link
Copy Markdown
Member

roycaihw commented Nov 20, 2018

FYI, a WIP PR is opened to address the issues: #71192.

@liggitt liggitt deleted the revert-openapi-publish branch November 21, 2018 04:10
@liggitt liggitt mentioned this pull request Dec 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims dims approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

+1 more reviewer

@dougm dougm dougm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sttts sttts

@smarterclayton smarterclayton

@roycaihw roycaihw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

8 participants

@liggitt @sttts @k8s-ci-robot @dims @roycaihw @smarterclayton @cjwagner @dougm