Skip to content

always enable TokenRequest in GCE kube-up.sh#70850

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mikedanese:enabletr
Nov 13, 2018
Merged

always enable TokenRequest in GCE kube-up.sh#70850
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mikedanese:enabletr

Conversation

@mikedanese
Copy link
Copy Markdown
Member

@mikedanese mikedanese commented Nov 9, 2018

It's been beta since last release.

/kind cleanup
/sig gcp

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/gcp cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2018
@mikedanese mikedanese added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@mikedanese mikedanese force-pushed the enabletr branch 2 times, most recently from 3cae0a2 to 2a2ff03 Compare November 9, 2018 06:43
justinsb
justinsb reviewed Nov 9, 2018
View reviewed changes
cluster/gce/gci/configure-helper.sh Outdated
Copy link
Copy Markdown
Member

@justinsb justinsb Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this value isn't defaulting:

Error: service-account-signing-key-file, service-account-issuer, service-account-api-audiences and service-account-key-file should be specified together

Copy link
Copy Markdown
Member Author

@mikedanese mikedanese Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flags for this are all messed up... I'm going to fix them separately. For now, I"m not relying on the defaulting happening correctly.

@justinsb
Copy link
Copy Markdown
Member

justinsb commented Nov 9, 2018

I think those test failures look real, --service-account-api-audiences not defaulting.

Otherwise lgtm :-)

@mikedanese mikedanese added this to the v1.13 milestone Nov 12, 2018
@cjcullen
Copy link
Copy Markdown
Member

cjcullen commented Nov 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@mikedanese mikedanese added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Nov 12, 2018
@mikedanese mikedanese added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit b31f9cb into kubernetes:master Nov 13, 2018
@mikedanese mikedanese deleted the enabletr branch November 13, 2018 08:05
@mikedanese mikedanese mentioned this pull request Nov 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwielgus mwielgus Awaiting requested review from mwielgus

@vishh vishh Awaiting requested review from vishh

1 more reviewer

@justinsb justinsb justinsb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cjcullen cjcullen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

4 participants

@mikedanese @k8s-ci-robot @justinsb @cjcullen