Skip to content

Sync PSP v1beta1 api definitions with internals#69704

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yue9944882:chore/sync-psp-api
Oct 13, 2018
Merged

Sync PSP v1beta1 api definitions with internals#69704
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yue9944882:chore/sync-psp-api

Conversation

@yue9944882
Copy link
Copy Markdown
Member

@yue9944882 yue9944882 commented Oct 11, 2018 •
edited
Loading

a sync up for missing definitions

/sig auth
/sig api-machinery
/kind cleanup

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2018
@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Oct 11, 2018
yue9944882
yue9944882 commented Oct 11, 2018
View reviewed changes
staging/src/k8s.io/api/policy/v1beta1/types.go
// field and means that any capabilities are allowed to be requested.
var AllowAllCapabilities v1.Capability = "*"

var (
Copy link
Copy Markdown
Member Author

@yue9944882 yue9944882 Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, any deprecated types here? since the lists growing 😥

@yue9944882
Copy link
Copy Markdown
Member Author

yue9944882 commented Oct 11, 2018

/assign @php-coder @tallclair @liggitt
/cc @caesarxuchao
/cc @deads2k since it might be a blocker of PSP admission controller externalizing

@k8s-ci-robot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot requested a review from deads2k October 11, 2018 22:21
@yue9944882 yue9944882 mentioned this pull request Oct 11, 2018
Merged
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 12, 2018

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2018
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 12, 2018

/approve
/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 12, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@php-coder
Copy link
Copy Markdown
Contributor

php-coder commented Oct 12, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 12, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 12, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@caesarxuchao
Copy link
Copy Markdown
Contributor

caesarxuchao commented Oct 12, 2018

/retest

tallclair
tallclair reviewed Oct 12, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I diff'd this file with the internal, and found a few more discrepencies:

  • a bunch of fields are missing +optional
  • a few typos / minor discrepencies in comments (cleanup otional)

staging/src/k8s.io/api/policy/v1beta1/types.go

// AllowAllCapabilities can be used as a value for the PodSecurityPolicy.AllowAllCapabilities
// field and means that any capabilities are allowed to be requested.
var AllowAllCapabilities v1.Capability = "*"
Copy link
Copy Markdown
Member

@tallclair tallclair Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move above FSType for consistency.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 12, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 521028e into kubernetes:master Oct 13, 2018
This was referenced Oct 15, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enisoc enisoc Awaiting requested review from enisoc

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@deads2k deads2k Awaiting requested review from deads2k

1 more reviewer

@tallclair tallclair tallclair left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@php-coder php-coder

@liggitt liggitt

@tallclair tallclair

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yue9944882 @k8s-ci-robot @liggitt @fejta-bot @php-coder @caesarxuchao @tallclair