dry-run: Promote from Alpha to Beta#69644
Conversation
|
/assign @lavalamp |
|
Is this the only change needed? |
|
We need to update the documentation, but the release branch hasn't been created yet. We don't want to change the default for the webhook configuration before GA, so I do think it is. |
|
See #68514 |
|
/approve To give @deads2k / @smarterclayton / @liggitt a chance to weigh in: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
could keep this to make sure things still respect the feature gate being disabled until it is removed (with a call to defer utilfeaturetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.DryRun, false)())
There was a problem hiding this comment.
Yes, agreed, makes sense to me
|
other than the comment on the test, lgtm |
ce0b9a3 to
5dbc5c6
Compare
Also remove the test that used to check that the dry-run flag is forbidden.
5dbc5c6 to
5dca8e0
Compare
|
/lgtm |
|
/kind feature |
|
/retest |
|
/hold cancel |
Also remove the test that used to check that the dry-run flag is
forbidden.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: