Skip to content

Fixes webhook test failures#69568

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
claudiubelu:fixes-webhook-test
Oct 12, 2018
Merged

Fixes webhook test failures#69568
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
claudiubelu:fixes-webhook-test

Conversation

@claudiubelu
Copy link
Copy Markdown
Contributor

@claudiubelu claudiubelu commented Oct 9, 2018 •
edited
Loading

What this PR does / why we need it:

The test "Should be able to deny attaching pod" can randomly fail
because it never waits for the pod to enter a "Running" state. Because
of this, the "kubectl attach" command can potentially fail, if the pod is
not in the correct state.

Additionally, if the "kubectl attach" actually manages to attach, then the
test will hang. The command should be executed with a timeout.

/kind bug
/sig testing

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69567

Special notes for your reviewer:

Release note:

NONE

@claudiubelu
Fixes webhook test failures
6db2dad 
The test "Should be able to deny attaching pod" can randomly fail
because it never waits for the pod to enter a "Running" state. Because
of this, the "kubectl attach" command can potentially fail, if the pod is
not in the correct state.

Additionally, if the "kubectl attach" actually manages to attach, then the
test will hang. The command should be executed with a timeout.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2018
@k8s-ci-robot k8s-ci-robot requested review from enisoc and ixdy October 9, 2018 11:34
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 9, 2018
@claudiubelu
Copy link
Copy Markdown
Contributor Author

claudiubelu commented Oct 9, 2018

/assign @ixdy

@PatrickLang
Copy link
Copy Markdown
Contributor

PatrickLang commented Oct 9, 2018

/milestone 1.13
We need this to fix tests running on Windows so we can enable the periodic test runs

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 9, 2018

@PatrickLang: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

Details

In response to this:

/milestone 1.13
We need this to fix tests running on Windows so we can enable the periodic test runs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Copy Markdown
Member

feiskyer commented Oct 10, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2018
@ixdy
Copy link
Copy Markdown
Contributor

ixdy commented Oct 11, 2018

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2018
@ixdy
Copy link
Copy Markdown
Contributor

ixdy commented Oct 11, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bclau, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2018
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 11, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

3 similar comments
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 11, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 11, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 12, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b516a99 into kubernetes:master Oct 12, 2018
@claudiubelu claudiubelu mentioned this pull request Feb 20, 2019
Closed
6 tasks
@claudiubelu claudiubelu deleted the fixes-webhook-test branch April 19, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enisoc enisoc Awaiting requested review from enisoc

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@ixdy ixdy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

webhook test can randomly fail because it never waits for the pod to be Running

6 participants

@claudiubelu @PatrickLang @k8s-ci-robot @feiskyer @ixdy @fejta-bot