Skip to content

Revert "Merge pull request #66960 from rosti/drop-arch-suffixes"#68394

Closed
mkumatag wants to merge 1 commit intokubernetes:masterfrom
mkumatag:revert_66960
Closed

Revert "Merge pull request #66960 from rosti/drop-arch-suffixes"#68394
mkumatag wants to merge 1 commit intokubernetes:masterfrom
mkumatag:revert_66960

Conversation

@mkumatag
Copy link
Copy Markdown
Member

@mkumatag mkumatag commented Sep 7, 2018

This reverts commit 5774bf1, reversing
changes made to d46d671.

This is for reverting the made in #66960 (comment) which requires the kubernetes/release#622 which is not yet merged.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

/cc @dims @neolit123 @rosti

@mkumatag
Revert "Merge pull request kubernetes#66960 from rosti/drop-arch-suff…
8ea44b2 
…ixes"

This reverts commit 5774bf1, reversing
changes made to d46d671.
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 7, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 7, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkumatag
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fabriziopandini

If they are not already assigned, you can assign the PR to them by writing /assign @fabriziopandini in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2018
@mkumatag mkumatag mentioned this pull request Sep 7, 2018
Merged
@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Sep 7, 2018 •
edited
Loading

/hold

@mkumatag
we are not reverting this until we are sure the manifest lists support will become available.
otherwise if we revert now we might have to apply the same patch later.

/assign @dims
/assign @neolit123

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2018
@dims
Copy link
Copy Markdown
Member

dims commented Sep 9, 2018

beta.2 will have manifests. kubernetes/release#622 got merged and we were able to try it out in a mock release

/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 9, 2018

@dims: Closing this PR.

Details

In response to this:

beta.2 will have manifests. kubernetes/release#622 got merged and we were able to try it out in a mock release

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@neolit123 neolit123 Awaiting requested review from neolit123

@rosti rosti Awaiting requested review from rosti

Assignees

@dims dims

@neolit123 neolit123

Labels

area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkumatag @k8s-ci-robot @neolit123 @dims