KubeletPluginsWatcher feature is beta in 1.12 release by RenaudWasTaken · Pull Request #68200 · kubernetes/kubernetes

RenaudWasTaken · 2018-09-03T23:25:08Z

What this PR does / why we need it:
Graduates DevicePlugins feature to beta.

Which issue(s) this PR fixes:
Related but does not fix: kubernetes/enhancements#595 as well as #65773

Special notes for your reviewer:
Includes upgrading the gRPC pluginwatcher API to beta. Based on the device plugin model.

Depends on #64621 being merged

Release note:

KubeletPluginsWatcher feature graduates to beta.

/sig node
/sig storage

/cc @vladimirvivien @sbezverk @vikaschoudhary16 @saad-ali @vishh @jiayingz

saad-ali · 2018-09-03T23:28:14Z

/milestone 1.12

k8s-ci-robot · 2018-09-03T23:28:15Z

@saad-ali: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.10, v1.11, v1.12, v1.13, v1.4, v1.5, v1.6, v1.7, v1.8, v1.9]

Use /milestone clear to clear the milestone.

Details

In response to this:

/milestone 1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saad-ali · 2018-09-03T23:28:26Z

/milestone v1.12

saad-ali

/lgtm
/approve

RenaudWasTaken · 2018-09-04T10:22:14Z

Updated hack/.golint_failures to ignore the lint failures of the generated gRPC file

RenaudWasTaken · 2018-09-04T17:51:47Z

/retest

vishh

Can you summarize the level of test coverage that we have for this feature?
How confident are we with the API?

vishh · 2018-09-04T18:11:14Z

pkg/kubelet/apis/pluginregistration/v1beta1/api.proto

nit: Fix indentation.

RenaudWasTaken · 2018-09-04T18:28:30Z

PR updated to fix the indentation.

@vishh

Can you summarize the level of test coverage that we have for this feature?
How confident are we with the API?

80.6% go test coverage
We have a few unit test coverage of this feature on the device plugin side
I believe we have e2e node test coverage of this feature
We have an in flight PR on the device plugin side for e2e tests
E2E tests for the CSI side will probably be in the next cycle

This is also the feature that CSI uses for it's plugins.

IMHO I'm confident the API won't need to be changed.

saad-ali · 2018-09-05T00:25:52Z

/lgtm

verult · 2018-09-05T01:13:31Z

@RenaudWasTaken the CSI test failure is likely due to missing driver-registrar params, so CSI driver isn't getting registered by the kubelet registration mechanism. Try this:
verult@666eff4

fejta-bot · 2018-09-05T03:22:47Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-09-05T06:52:48Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-09-05T10:43:48Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

RenaudWasTaken · 2018-09-05T13:58:58Z

@verult thanks! I added pulled your patch on top

RenaudWasTaken · 2018-09-05T14:26:40Z

/retest

vladimirvivien · 2018-09-05T17:11:55Z

/lgtm

vladimirvivien · 2018-09-05T17:13:33Z

/priority critical-urgent

vladimirvivien

I lgtm'd it

childsb · 2018-09-05T18:44:12Z

/lgtm

k8s-ci-robot · 2018-09-05T18:44:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, RenaudWasTaken, saad-ali, vishh, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [vishh]
~~pkg/features/OWNERS~~ [childsb,saad-ali]
~~pkg/kubelet/OWNERS~~ [vishh]
~~test/OWNERS~~ [saad-ali,vishh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

childsb · 2018-09-05T18:44:40Z

/kind feature

k8s-github-robot · 2018-09-05T19:10:42Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-09-05T20:18:38Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 3, 2018

k8s-ci-robot requested review from jiayingz, saad-ali, sbezverk, vikaschoudhary16, vishh and vladimirvivien September 3, 2018 23:25

k8s-ci-robot added this to the v1.12 milestone Sep 3, 2018

saad-ali approved these changes Sep 3, 2018

View reviewed changes

k8s-ci-robot assigned saad-ali Sep 3, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2018

RenaudWasTaken force-pushed the pluginwatcher-beta branch from e7d8015 to 7d47e11 Compare September 4, 2018 10:21

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018

vishh reviewed Sep 4, 2018

View reviewed changes

pkg/kubelet/apis/pluginregistration/v1beta1/api.proto Outdated

Copy link
Copy Markdown

Contributor

vishh Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Fix indentation.

RenaudWasTaken force-pushed the pluginwatcher-beta branch from 7d47e11 to 31aea70 Compare September 4, 2018 18:21

Renaud Gaubert added 3 commits September 4, 2018 20:22

Create pkg/kubelet/apis/pluginregistration/v1beta1 directory

f8e80e4

Add pluginwatcher generated files

44dd067

Graduates pluginwatcher feature to beta

a92bb07

RenaudWasTaken force-pushed the pluginwatcher-beta branch from 31aea70 to a92bb07 Compare September 4, 2018 18:23

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018

liggitt mentioned this pull request Sep 5, 2018

Limit kubelets from updating their own labels when NodeRestriction is enabled #68267

Merged

CSI e2e test: driver registrar updates for moving PluginWatcher to beta

add6e0d

k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 5, 2018

k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 5, 2018

vladimirvivien reviewed Sep 5, 2018

View reviewed changes

k8s-ci-robot assigned childsb Sep 5, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 5, 2018

k8s-github-robot merged commit 70a0089 into kubernetes:master Sep 5, 2018

ChiuWang mentioned this pull request Sep 6, 2018

update KubeletPluginsWatcher feature gate kubernetes/website#10205

Merged

mkimuram mentioned this pull request Sep 10, 2018

driver-registrar needs configurations to handle kubelet-plugin-watcher ceph/ceph-csi#73

Closed

RenaudWasTaken deleted the pluginwatcher-beta branch September 24, 2018 13:25

adisky mentioned this pull request Sep 27, 2018

Cinder CSI CI Tests are failing kubernetes/cloud-provider-openstack#297

Closed

Conversation

RenaudWasTaken commented Sep 3, 2018

Uh oh!

saad-ali commented Sep 3, 2018

Uh oh!

k8s-ci-robot commented Sep 3, 2018

Uh oh!

saad-ali commented Sep 3, 2018

Uh oh!

saad-ali left a comment

Choose a reason for hiding this comment

Uh oh!

RenaudWasTaken commented Sep 4, 2018

Uh oh!

RenaudWasTaken commented Sep 4, 2018

Uh oh!

vishh left a comment

Choose a reason for hiding this comment

Uh oh!

vishh Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

RenaudWasTaken commented Sep 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saad-ali commented Sep 5, 2018

Uh oh!

verult commented Sep 5, 2018

Uh oh!

fejta-bot commented Sep 5, 2018

Uh oh!

fejta-bot commented Sep 5, 2018

Uh oh!

fejta-bot commented Sep 5, 2018

Uh oh!

RenaudWasTaken commented Sep 5, 2018

Uh oh!

RenaudWasTaken commented Sep 5, 2018

Uh oh!

vladimirvivien commented Sep 5, 2018

Uh oh!

vladimirvivien commented Sep 5, 2018

Uh oh!

vladimirvivien left a comment

Choose a reason for hiding this comment

Uh oh!

childsb commented Sep 5, 2018

Uh oh!

k8s-ci-robot commented Sep 5, 2018

Uh oh!

childsb commented Sep 5, 2018

Uh oh!

k8s-github-robot commented Sep 5, 2018

Uh oh!

k8s-github-robot commented Sep 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

RenaudWasTaken commented Sep 4, 2018 •

edited

Loading