CSI pod information in NodePublish#67945
Merged
k8s-github-robot merged 5 commits intokubernetes:masterfrom Sep 6, 2018
Merged
Conversation
3803f67 to
94aa1e9
Compare
Member
94aa1e9 to
794ac4f
Compare
794ac4f to
102f357
Compare
Member
|
@saad-ali I have rebased this against master. PTAL. |
102f357 to
1eff25e
Compare
Member
|
/assign @liggitt for the small auth change |
|
lgtm too. |
Member
|
/approve |
Contributor
|
re-adding |
85778fd to
a517197
Compare
Member
|
/test pull-kubernetes-e2e-kops-aws |
Contributor
|
/lgtm |
Member
|
/test pull-kubernetes-kubemark-e2e-gce-big |
Contributor
|
/milestone v1.12 |
Nodes need to watch CSIDrivers to know if they should send pod information in NodePublish.
a517197 to
f2bc681
Compare
Some refactoring of CSI tests was necessary.
f2bc681 to
32ae639
Compare
Member
|
LGTM'ing rebase /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: childsb, jsafrane, liggitt, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 68171, 67945, 68233). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is implementation of kubernetes/community#2439. It brings CSI closer to Flex volume features, CSI driver can (optionally) get name/namespace/UID/ServiceAccount of the pod that requires the CSI volume mounted. This allows CSI drivers to either do AAA before the volume is mounted or tailor content of volume to the pod.
Work in progress:
CSIDriverAPI. Ignore the first commit.Related to #64984 #66362 (fixes only part of these issues)
/sig storage
cc: @saad-ali @vladimirvivien @verult @msau42 @gnufied
Release note: