Skip to content

WaitForAllNodesSchedulable should check taints as well#67766

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
mborsz:taints
Aug 27, 2018
Merged

WaitForAllNodesSchedulable should check taints as well#67766
k8s-github-robot merged 1 commit intokubernetes:masterfrom
mborsz:taints

Conversation

@mborsz
Copy link
Copy Markdown
Member

@mborsz mborsz commented Aug 23, 2018

What this PR does / why we need it:
In #67597 we see a lot of cases when test starts before not-ready and network-unavailable taints are removed from the nodes while they already have correct conditions.
This change makes sure that we wait for both.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

Release note:

NONE

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 23, 2018
@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 23, 2018

/retest

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Aug 23, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2018
@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 23, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2018
@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 23, 2018

PTAL

@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 23, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2018
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Aug 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2018
@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 23, 2018

/test pull-kubernetes-e2e-kops-aws

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Aug 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

4 similar comments
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Aug 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Aug 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Aug 24, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Aug 24, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2018
@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 24, 2018

I need to debug this on AWS, will let know when it's done.

@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 24, 2018

/retest

@wojtek-t wojtek-t mentioned this pull request Aug 24, 2018
Closed
@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 24, 2018

I think it should be ok now, PTAL

@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 27, 2018

PTAL

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Aug 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 27, 2018

/retest

1 similar comment
@mborsz
Copy link
Copy Markdown
Member Author

mborsz commented Aug 27, 2018

/retest

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 27, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 27, 2018

@mborsz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 57c0e41 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 27, 2018

Automatic merge from submit-queue (batch tested with PRs 67766, 67642, 67772). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a0208cd into kubernetes:master Aug 27, 2018
@BenTheElder BenTheElder mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enisoc enisoc Awaiting requested review from enisoc

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mborsz @wojtek-t @fejta-bot @k8s-ci-robot @k8s-github-robot