/cc @nikhita

Still need to write stuff up on this one, but figured I might as well throw it in front of CI while I grab some lunch.

@cblecker just a heads up that once #67635 merges, the list would need to be updated again.

/cc @spxtr
since you had updated this file previously

This is what the failures look like now that it's actually looking at all files:
https://gist.github.com/cblecker/55b0f86d93b5b7c6d6857d68f35668fc

Adding some more details so that if someone comes across this, it's easier for them to understand the line of thought. :)

When we pass multiple files into golint at once, and golint detects a fatal error in one of them, it will actually exit and not process any more of the files passed.

This is due to an existing golint bug: golang/lint#68 (comment). If we lint a package using golint p/*.go and the package p contains test files with the package name p_test, this gives a fatal error, something like:

staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured/unstructured_test.go is in package unstructured_test, not unstructured

and skips the linting. Current behaviour was to ignore this error, which also meant that we ignored the linting of these packages all together.

Also, it's not possible to lint the whole package together through golint p because that would not lint _test.go files due to another golint bug: golang/lint#200.

This change will, instead of golinting once per package, will use xargs to run each file through golint individually.

And so we use xargs to make sure we are linting all files and don't hit any errors. ✨

@nikhita Addressed your feedback. PTAL!

Also thanks for the amazing write up ✨ 🗒 ! I linked to this PR in the comments to so future bash spelunkers will be able to find it! :bash:

I linked to this PR in the comments to so future bash spelunkers will be able to find it!

🎉

/lgtm
/retest

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Automatic merge from submit-queue (batch tested with PRs 67378, 67675, 67654). If you want to cherry-pick this change to another branch, please follow the instructions here.