build/debian-iptables: make: support arguments for base and tag#67673
Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom Aug 22, 2018
javier-b-perez:debian-iptables
Merged
build/debian-iptables: make: support arguments for base and tag#67673k8s-github-robot merged 1 commit intokubernetes:masterfrom javier-b-perez:debian-iptables
k8s-github-robot merged 1 commit intokubernetes:masterfrom
javier-b-perez:debian-iptables
Conversation
Member
|
/ok-to-test |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, javier-b-perez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 67298, 67518, 67635, 67673). If you want to cherry-pick this change to another branch, please follow the instructions here. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Change debian-iptables makefile to support arguments for base image and tag.
Special notes for your reviewer:
Tested locally.
Release note: