apiextensions: improve patch integration test#67637
apiextensions: improve patch integration test#67637sttts wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
@sttts: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3ce7c54 to
38ae874
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| } | ||
| } | ||
|
|
||
| func expectInt64(t *testing.T, obj map[string]interface{}, value int64, pth ...string) { |
There was a problem hiding this comment.
can we add this in helpers.go? Looks super useful honestly.
| if err != nil { | ||
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
| expectInt64(t, createdNoxuInstance.UnstructuredContent(), 999, "num", "num2") |
There was a problem hiding this comment.
we should also add this for TestSubresourcePatch for consistency
There was a problem hiding this comment.
Can you do that in a follow-up? Feel free to move the helpers.
|
@sttts: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sttts: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Picked into #67562. Closing this. /close |
Depends on #67635 for being green.