Add unit tests for webhooks with dry run#67099
Merged
k8s-github-robot merged 2 commits intokubernetes:masterfrom Aug 15, 2018
Merged
Add unit tests for webhooks with dry run#67099k8s-github-robot merged 2 commits intokubernetes:masterfrom
k8s-github-robot merged 2 commits intokubernetes:masterfrom
Conversation
Member
|
/sig api-machinery |
Contributor
|
/assign @lavalamp |
Contributor
|
/lgtm |
lavalamp
approved these changes
Aug 14, 2018
| if attr.IsDryRun() { | ||
| // TODO: support this | ||
| webhookerrors.NewDryRunUnsupportedErr(h.Name) | ||
| return webhookerrors.NewDryRunUnsupportedErr(h.Name) |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jennybuckley, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes an issue with #67085 and adds a couple test cases that would catch it.
@lavalamp
Release note: