Skip to content

Automated cherry pick of #66925: Rework multi-volume test to use StatefulSet#66977

Merged
k8s-github-robot merged 1 commit intokubernetes:release-1.10from
msau42:automated-cherry-pick-of-#66925-upstream-release-1.10
Aug 6, 2018
Merged

Automated cherry pick of #66925: Rework multi-volume test to use StatefulSet#66977
k8s-github-robot merged 1 commit intokubernetes:release-1.10from
msau42:automated-cherry-pick-of-#66925-upstream-release-1.10

Conversation

@msau42
Copy link
Copy Markdown
Member

@msau42 msau42 commented Aug 3, 2018

Cherry pick of #66925 on release-1.10.

#66925: Rework multi-volume test to use StatefulSet

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 3, 2018

@msau42: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

Details

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #66925.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 3, 2018

@msau42: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 3, 2018
@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 3, 2018

/release-note-none
/assign David Zhu
/hold
wait for master tests to pass

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 3, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 3, 2018

@msau42: GitHub didn't allow me to assign the following users: David, Zhu.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

Details

In response to this:

/release-note-none
/assign David Zhu
/hold
wait for master tests to pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 3, 2018
@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 3, 2018

/assign @davidz627

@davidz627
Copy link
Copy Markdown
Contributor

davidz627 commented Aug 3, 2018

/lgtm
/assign @MaciekPytel

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 4, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2018
@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Aug 6, 2018

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 6, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 6, 2018
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 6, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 6, 2018

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit e98e71a into kubernetes:release-1.10 Aug 6, 2018
@msau42 msau42 deleted the automated-cherry-pick-of-#66925-upstream-release-1.10 branch November 17, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@davidz627 davidz627

@MaciekPytel MaciekPytel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@msau42 @k8s-ci-robot @davidz627 @neolit123 @k8s-github-robot @MaciekPytel