Skip to content

Automated cherry pick of #66832: Detect if GCE PD udev link is wrong and try to correct it#66880

Merged
k8s-github-robot merged 2 commits intokubernetes:release-1.9from
msau42:automated-cherry-pick-of-#66832-upstream-release-1.9
Aug 29, 2018
Merged

Automated cherry pick of #66832: Detect if GCE PD udev link is wrong and try to correct it#66880
k8s-github-robot merged 2 commits intokubernetes:release-1.9from
msau42:automated-cherry-pick-of-#66832-upstream-release-1.9

Conversation

@msau42
Copy link
Copy Markdown
Member

@msau42 msau42 commented Aug 2, 2018 •
edited
Loading

Cherry pick of #66832 on release-1.9.

#66832: Detect if GCE PD udev link is wrong and try to correct it

#66925: Rework multi-volume test to use StatefulSet

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2018
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 2, 2018

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 2, 2018
@saad-ali saad-ali added this to the v1.9 milestone Aug 2, 2018
saad-ali
saad-ali approved these changes Aug 2, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2018
@saad-ali saad-ali added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Aug 2, 2018
@davidz627
Copy link
Copy Markdown
Contributor

davidz627 commented Aug 2, 2018

/assign @mbohlool
for cherry-pick approval

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 2, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@mbohlool @msau42 @saad-ali

Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 2, 2018

/hold
e2e test is failing in multi-zone environment, I am working on a fix

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 2, 2018
@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 4, 2018

/hold cancel
I cherry picked the e2e fix too

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2018
@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 4, 2018

/assign @davidz627

@msau42 msau42 force-pushed the automated-cherry-pick-of-#66832-upstream-release-1.9 branch from d1d55ff to 6096e9c Compare August 4, 2018 00:54
@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 4, 2018

I had to make extra changes to the e2e test because the StatefulSet utils were using v1beta1 in 1.9

@davidz627
Copy link
Copy Markdown
Contributor

davidz627 commented Aug 6, 2018 •
edited
Loading

@msau42 I think the test is failing in CI

@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 6, 2018

yes i'm debugging. the e2e test utils are different in 1.9 because statefulset was beta.

@msau42 msau42 force-pushed the automated-cherry-pick-of-#66832-upstream-release-1.9 branch from 6096e9c to 0755f4c Compare August 6, 2018 20:27
@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 6, 2018

/test pull-kubernetes-e2e-kops-aws

@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 6, 2018

the new e2e looks good now

davidz627
davidz627 reviewed Aug 7, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidz627 davidz627 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, lgtm besides that

test/e2e/storage/persistent_volumes.go
Expect(err).NotTo(HaveOccurred())
ssTester.WaitForStatusReplicas(ss, 0)
// Set OrphanDependent=false so it's deleted synchronously
err = c.AppsV1beta1().StatefulSets(ns).Delete(ss.Name, &metav1.DeleteOptions{OrphanDependents: new(bool)})
Copy link
Copy Markdown
Contributor

@davidz627 davidz627 Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is new(bool)==false?

Copy link
Copy Markdown
Member Author

@msau42 msau42 Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@davidz627
Copy link
Copy Markdown
Contributor

davidz627 commented Aug 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidz627
Copy link
Copy Markdown
Contributor

davidz627 commented Aug 8, 2018

/assign @mbohlool
for cherry-pick approval

@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 11, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@davidz627
Copy link
Copy Markdown
Contributor

davidz627 commented Aug 15, 2018

ping @mbohlool

@msau42
Copy link
Copy Markdown
Member Author

msau42 commented Aug 21, 2018

/retest

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 29, 2018
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Aug 29, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 29, 2018

@msau42: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 0755f4c link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 29, 2018

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit c7a3abc into kubernetes:release-1.9 Aug 29, 2018
@msau42 msau42 deleted the automated-cherry-pick-of-#66832-upstream-release-1.9 branch November 17, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

2 more reviewers

@davidz627 davidz627 davidz627 left review comments

@saad-ali saad-ali saad-ali approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mbohlool mbohlool

@davidz627 davidz627

@saad-ali saad-ali

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.9

Development

Successfully merging this pull request may close these issues.

7 participants

@msau42 @k8s-github-robot @davidz627 @k8s-ci-robot @fejta-bot @saad-ali @mbohlool