Skip to content

use pause image with fat-manifest#66052

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
lubinsz:master
Aug 28, 2018
Merged

use pause image with fat-manifest#66052
k8s-github-robot merged 1 commit intokubernetes:masterfrom
lubinsz:master

Conversation

@lubinsz
Copy link
Copy Markdown

@lubinsz lubinsz commented Jul 11, 2018 •
edited
Loading

What this PR does / why we need it:
Pause manifest code is merged in #57723, so we should use new image in test.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

use pause image with fat-manifest
773ab3f 
Signed-off-by: Bin Lu <bin.lu@arm.com>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 11, 2018

@lubinsz: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2018
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jul 11, 2018
@dims
Copy link
Copy Markdown
Member

dims commented Jul 12, 2018

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2018
@lubinsz
Copy link
Copy Markdown
Author

lubinsz commented Jul 18, 2018

hi @dims
It seems that the failed case has nothing to do with my modification.
Thanks.

@dims
Copy link
Copy Markdown
Member

dims commented Jul 18, 2018

/test pull-kubernetes-integration

@dims
Copy link
Copy Markdown
Member

dims commented Jul 31, 2018

/test pull-kubernetes-integration
/assign @fabriziopandini

@fabriziopandini
Copy link
Copy Markdown
Member

fabriziopandini commented Aug 2, 2018

@lubinsz sorry for the delay in responding but I was ooo
Could you kindly provide a little bit of background?
Does that means that there will be only one pause image from now on (without -arch suffix)? Does this affect also older kubeadm releases or only v1.12?

@lubinsz
Copy link
Copy Markdown
Author

lubinsz commented Aug 13, 2018

@fabriziopandini
Hi,
Pause manifest code is merged in #57723.
It means, starting from 1.12, different platforms use the same name image with fat-manifest.
So, the advantage of doing this is that, even in Arm platform, we can also run the test case with
the same name pause image: k8s.gcr.io/pause:3.1

@dims
Copy link
Copy Markdown
Member

dims commented Aug 20, 2018

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 20, 2018
@lubinsz
Copy link
Copy Markdown
Author

lubinsz commented Aug 20, 2018

ping @fabriziopandini

timothysc
timothysc approved these changes Aug 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lubinsz, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2018
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 27, 2018

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 28, 2018

Automatic merge from submit-queue (batch tested with PRs 66085, 66052). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f0e2a24 into kubernetes:master Aug 28, 2018
@lubinsz lubinsz mentioned this pull request Jun 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@detiber detiber Awaiting requested review from detiber

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

1 more reviewer

@timothysc timothysc timothysc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@timothysc timothysc

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

6 participants

@lubinsz @k8s-ci-robot @dims @fabriziopandini @k8s-github-robot @timothysc