Skip to content

Fix a changelog entry in v1.11#65231

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
luxas:fix_changelog
Jun 19, 2018
Merged

Fix a changelog entry in v1.11#65231
k8s-github-robot merged 1 commit intokubernetes:masterfrom
luxas:fix_changelog

Conversation

@luxas
Copy link
Copy Markdown
Member

@luxas luxas commented Jun 19, 2018

What this PR does / why we need it:
Fixes the comment in #64792 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Do we want to merge this now?

Release note:

NONE

@php-coder @jberkus @timothysc
/kind cleanup
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added retest-not-required-docs-only release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2018
timothysc
timothysc approved these changes Jun 19, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2018
@timothysc timothysc added this to the v1.11 milestone Jun 19, 2018
@luxas
Copy link
Copy Markdown
Member Author

luxas commented Jun 19, 2018

/milestone v1.11
/status approved-for-milestone

@timothysc timothysc added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 19, 2018
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jun 19, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@jberkus @luxas @timothysc

Pull Request Labels
  • sig/cluster-lifecycle: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@luxas luxas mentioned this pull request Jun 19, 2018
Merged
@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: luxas, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jun 19, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3994829 into kubernetes:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

2 more reviewers

@timothysc timothysc timothysc approved these changes

@nickchase nickchase nickchase approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jberkus jberkus

@timothysc timothysc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

6 participants

@luxas @k8s-github-robot @k8s-ci-robot @timothysc @nickchase @jberkus