Skip to content

add missing LastTransitionTime of ContainerReady condition#64867

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
dixudx:missing_container_ready_ltt
Sep 9, 2018
Merged

add missing LastTransitionTime of ContainerReady condition#64867
k8s-github-robot merged 1 commit intokubernetes:masterfrom
dixudx:missing_container_ready_ltt

Conversation

@dixudx
Copy link
Copy Markdown
Member

@dixudx dixudx commented Jun 7, 2018

What this PR does / why we need it:
add missing LastTransitionTime of ContainerReady condition

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #64646

Special notes for your reviewer:
/cc freehan yujuhong

Release note:

add missing LastTransitionTime of ContainerReady condition

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 7, 2018
@k8s-ci-robot k8s-ci-robot requested a review from freehan June 7, 2018 06:55
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2018
@k8s-ci-robot k8s-ci-robot requested a review from yujuhong June 7, 2018 06:55
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2018
@dixudx
Copy link
Copy Markdown
Member Author

dixudx commented Jun 7, 2018

/retest

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 5, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 5, 2018
@yujuhong yujuhong removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 5, 2018
@yujuhong
Copy link
Copy Markdown
Contributor

yujuhong commented Sep 5, 2018

/lgtm

Thanks for the PR!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2018
@yujuhong yujuhong added this to the v1.12 milestone Sep 5, 2018
@yujuhong yujuhong added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 5, 2018
@yujuhong
Copy link
Copy Markdown
Contributor

yujuhong commented Sep 5, 2018

/retest

@dims
Copy link
Copy Markdown
Member

dims commented Sep 8, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 8, 2018
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 9, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 60ec6bf into kubernetes:master Sep 9, 2018
@dixudx dixudx deleted the missing_container_ready_ltt branch September 9, 2018 12:02
@marpaia marpaia mentioned this pull request Sep 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freehan freehan Awaiting requested review from freehan

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@yujuhong yujuhong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

6 participants

@dixudx @fejta-bot @yujuhong @k8s-ci-robot @dims @k8s-github-robot