apiextensions: allow Description at root with status subresource#64766
Conversation
|
|
||
| if name := v.Type().Field(i).Name; name != "Properties" && name != "Required" { | ||
| allErrs = append(allErrs, field.Invalid(fldPath.Child("openAPIV3Schema"), *schema, fmt.Sprintf(`must only have "properties" or "required" at the root if the status subresource is enabled`))) | ||
| if name := v.Type().Field(i).Name; name != "Properties" && name != "Required" && name != "Description" { |
There was a problem hiding this comment.
we should start to have a slice when we add the next one
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I think this needs lots of other labels. /kind bug |
|
And the milestone + |
|
@sttts Can you add the milestone? |
|
/priority important-soon |
|
/status approved-for-milestone |
|
You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to add status labels. |
|
looks like @sttts is ok to get this in /status approved-for-milestone |
|
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process Pull Request Labels
|
|
Thanks @dims! |
|
/retest |
1 similar comment
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 64276, 64094, 64719, 64766, 64750). If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
/cc @mbohlool |
Allows
Descriptionat the root of the schema when the status subresource is enabled.Release note:
I'll update the original PR, which allowed
Required, to de-duplicate the release notes./assign sttts