Skip to content

Mount the kubeletConfigPath rw when running containerized node e2e tests#64556

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
ingvagabund:e2e_node-containerized-make-kubeletConfigPath-rw
Jun 1, 2018
Merged

Mount the kubeletConfigPath rw when running containerized node e2e tests#64556
k8s-github-robot merged 1 commit intokubernetes:masterfrom
ingvagabund:e2e_node-containerized-make-kubeletConfigPath-rw

Conversation

@ingvagabund
Copy link
Copy Markdown
Contributor

@ingvagabund ingvagabund commented May 31, 2018 •
edited
Loading

The kubelet needs to create dynamic-kubelet-config directory under the kubeletConfigPath
when initialing dynamic config directory.

What this PR does / why we need it:
Without the patch the https://k8s-testgrid.appspot.com/sig-node-kubelet#kubelet-containerized-conformance-aws-e2e-rhel fails.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Started to occur after merging #64275

Release note:

NONE

@ingvagabund
Mount the kubeletConfigPath rw when running containerized node e2e tests
ee83021 
The kubelet needs to create dynamic-kubelet-config directory under the kubeletConfigPath
when initialing dynamic config directory.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2018
@k8s-ci-robot k8s-ci-robot requested review from Random-Liu and dims May 31, 2018 12:51
@sjenning
Copy link
Copy Markdown
Contributor

sjenning commented May 31, 2018

/lgtm
/assign @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2018
@derekwaynecarr
Copy link
Copy Markdown
Member

derekwaynecarr commented May 31, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 31, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, ingvagabund, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2018
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented May 31, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 1, 2018 •
edited
Loading

@ingvagabund: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big ee83021 link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Copy Markdown
Contributor Author

ingvagabund commented Jun 1, 2018

@derekwaynecarr can we set the milestone to have the PR merged sooner?

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 1, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

4 similar comments
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 1, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 1, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 1, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 1, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@derekwaynecarr derekwaynecarr added this to the v1.11 milestone Jun 1, 2018
@derekwaynecarr
Copy link
Copy Markdown
Member

derekwaynecarr commented Jun 1, 2018

/status approved-for-milestone
/priority important-soon

@k8s-ci-robot k8s-ci-robot added status/approved-for-milestone priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 1, 2018
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jun 1, 2018

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@derekwaynecarr @ingvagabund @sjenning

Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.11 milestone.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
sig owner: Must specify at least one label prefixed with sig/.

Help

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jun 1, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jun 1, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c2848da into kubernetes:master Jun 1, 2018
@ingvagabund ingvagabund deleted the e2e_node-containerized-make-kubeletConfigPath-rw branch June 1, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@sjenning sjenning

@derekwaynecarr derekwaynecarr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

6 participants

@ingvagabund @sjenning @derekwaynecarr @k8s-ci-robot @fejta-bot @k8s-github-robot