Skip to content

kubeadm: rename the kube-dns phases addon#64274

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
neolit123:kubeadm-alpha-phase-addon
May 29, 2018
Merged

kubeadm: rename the kube-dns phases addon#64274
k8s-github-robot merged 1 commit intokubernetes:masterfrom
neolit123:kubeadm-alpha-phase-addon

Conversation

@neolit123
Copy link
Copy Markdown
Member

@neolit123 neolit123 commented May 24, 2018

What this PR does / why we need it:
The command kubeadm alpha phases addon has a property
called kube-dns which would install kube-dns, pre 1.11.

In the case of 1.11 this property will install CoreDNS,
because the property is also bound to the CoreDNS feature gate,
which is now true by default.

Fix that by renaming the property to coredns, updating the Cobra
info and also updating the unit tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/kubeadm#856

Special notes for your reviewer:
Please verify if we are OK with the "hard rename".

Release note:

kubeadm: rename the addon parameter `kube-dns` to `coredns` for `kubeadm alpha phases addons` as CoreDNS is now the default DNS server in 1.11.

@kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2018
@k8s-ci-robot k8s-ci-robot requested review from kad and luxas May 24, 2018 16:58
@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented May 24, 2018 •
edited
Loading

/kind bug
/area ux

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 24, 2018
@neolit123 neolit123 mentioned this pull request May 24, 2018
Merged
@neolit123 neolit123 force-pushed the kubeadm-alpha-phase-addon branch from 0f68acb to 336184c Compare May 24, 2018 17:33
@neolit123 neolit123 force-pushed the kubeadm-alpha-phase-addon branch from 336184c to 9c9a2fe Compare May 24, 2018 18:10
@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented May 24, 2018

FYI @timothysc mentioned this on slack:

Just keep in mind that in 1.12 we are planning to eliminate phases in favor for the sub-commands like init

@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented May 24, 2018

/test pull-kubernetes-integration

@neolit123
kubeadm: rename the kube-dns phases addon
ebc254c 
The command `kubeadm alpha phases addon` has a property
called `kube-dns` which would install kube-dns, pre 1.11.

In the case of 1.11 this property will install CoreDNS,
because the property is also bound to the `CoreDNS` feature gate,
which is now `true` by default.

Fix that by renaming the property to `coredns`, updating the Cobra
info and also updating the unit tests.
@neolit123 neolit123 force-pushed the kubeadm-alpha-phase-addon branch from 9c9a2fe to ebc254c Compare May 24, 2018 19:08
timothysc
timothysc approved these changes May 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I'm ok with this change, I'll let @detiber have final lgtm.

@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2018
@timothysc
Copy link
Copy Markdown
Contributor

timothysc commented May 25, 2018

/assign @detiber

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented May 27, 2018

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 27, 2018

@tengqm: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

luxas
luxas approved these changes May 28, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @neolit123!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: luxas, neolit123, tengqm, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented May 29, 2018

Automatic merge from submit-queue (batch tested with PRs 64308, 64367, 64165, 64274). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 046619f into kubernetes:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kad kad Awaiting requested review from kad

2 more reviewers

@timothysc timothysc timothysc approved these changes

@luxas luxas luxas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@detiber detiber

@luxas luxas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rename the kube-dns property in kubeadm alpha phase addon

7 participants

@neolit123 @timothysc @tengqm @k8s-ci-robot @k8s-github-robot @luxas @detiber