Skip to content

fix the e2e node helpers that let tests reconfigure Kubelet#64173

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
mtaufen:node-e2e-dynamic-config-helper-fix
May 23, 2018
Merged

fix the e2e node helpers that let tests reconfigure Kubelet#64173
k8s-github-robot merged 1 commit intokubernetes:masterfrom
mtaufen:node-e2e-dynamic-config-helper-fix

Conversation

@mtaufen
Copy link
Copy Markdown
Contributor

@mtaufen mtaufen commented May 23, 2018 •
edited
Loading

The dynamic config tests were updated with the validation change, but
the tests that try to use dynamic config via this helper were not.

Should fix the failures here: https://k8s-testgrid.appspot.com/sig-node-kubelet#kubelet-serial-gce-e2e

NONE

@mtaufen
fix the e2e node helpers that let tests reconfigure Kubelet
0868db5 
The dynamic config tests were updated with the validation change, but
the tests that try to use dynamic config via this helper were not.
@mtaufen mtaufen added kind/bug Categorizes issue or PR as related to a bug. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels May 23, 2018
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 23, 2018
@k8s-ci-robot k8s-ci-robot requested review from resouer and yujuhong May 23, 2018 00:22
@mtaufen mtaufen mentioned this pull request May 23, 2018
Merged
@dashpole
Copy link
Copy Markdown
Contributor

dashpole commented May 23, 2018

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2018
@yujuhong
Copy link
Copy Markdown
Contributor

yujuhong commented May 23, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, mtaufen, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2018
@mtaufen
Copy link
Copy Markdown
Contributor Author

mtaufen commented May 23, 2018

/retest

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented May 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented May 23, 2018

Automatic merge from submit-queue (batch tested with PRs 63830, 63579, 64173). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 23d9a48 into kubernetes:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resouer resouer Awaiting requested review from resouer

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@dashpole dashpole

@Random-Liu Random-Liu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mtaufen @dashpole @yujuhong @k8s-ci-robot @fejta-bot @k8s-github-robot @Random-Liu