[kubeadm] Support HostPathType of ExtraVolumes in the kubeadm configuration file.#63452
Conversation
Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com>
HostPathType of ExtraVolumes in the kubeadm configuration file.HostPathType of ExtraVolumes in the kubeadm configuration file.
|
Ping @dmmcquay @xiangpengzhao |
|
/ok-to-test |
|
@kubernetes/sig-cluster-lifecycle-pr-reviews |
There was a problem hiding this comment.
Where is this defaulted, and what happens if it's an empty string?
There was a problem hiding this comment.
@timothysc The default value is an empty string. And it will create a volume like this:
volumes:
- hostPath:
path: /foo/bar
type: ""
name: test
And this will have the same behavior as the volume in which we do not specify the type of hostPath.
There was a problem hiding this comment.
/cc @liztio
B/c it's affecting config. You're basically adding a string for a v1-type. Why wouldn't you use the type itself?
|
@timothysc: GitHub didn't allow me to request PR reviews from the following users: liztio. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com>
|
@timothysc I updated this PR and use |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timothysc, xlgao-zju The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Now we use
DirectoryOrCreateas a defaultHostPathTypein the kubeadm configuration file, when we create user's extra volumes(likeapiServerExtraVolumes). So, user can't use otherHostPathType. In order to let users use other types ofHostPath(likeFile), I think we should supportHostPathTypeof ExtraVolumes in the kubeadm configuration file.Which issue(s) this PR fixes
ref kubernetes/kubeadm#788
Special notes for your reviewer:
Release note: