Improve kubeadm upgrade path for CoreDNS#63400
Improve kubeadm upgrade path for CoreDNS#63400k8s-github-robot merged 1 commit intokubernetes:masterfrom rajansandeep:corednsupgrade
Conversation
There was a problem hiding this comment.
I don't see why this is written as a closure vs part of the function itself?
There was a problem hiding this comment.
i would do this do remove one level of indentation:
func CreateOrRetainConfigMap(client clientset.Interface, cm *v1.ConfigMap, configMapName string) error {
if _, err := client.CoreV1().ConfigMaps(cm.ObjectMeta.Namespace).Get(configMapName, metav1.GetOptions{}); err != nil {
if !apierrors.IsNotFound(err) {
return nil
}
if _, err := client.CoreV1().ConfigMaps(cm.ObjectMeta.Namespace).Create(cm); err != nil {
if !apierrors.IsAlreadyExists(err) {
return fmt.Errorf("unable to create configmap: %v", err)
}
}
}
return nil
}|
/lgtm @timothysc I'm good with this merging separately, it does not conflict with #63509 |
|
/test pull-kubernetes-e2e-kops-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, rajansandeep, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 55511, 63372, 63400, 63100, 63769). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
This PR achieves the following:
kubeadm upgrade.kubeadm upgrade.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: