Skip to content

Automated cherry pick of #62654: Ensure service routing resolves kubernetes.default.svc#63219

Merged
k8s-github-robot merged 6 commits intokubernetes:release-1.9from
liggitt:automated-cherry-pick-of-#62654-upstream-release-1.9
May 15, 2018
Merged

Automated cherry pick of #62654: Ensure service routing resolves kubernetes.default.svc#63219
k8s-github-robot merged 6 commits intokubernetes:release-1.9from
liggitt:automated-cherry-pick-of-#62654-upstream-release-1.9

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Apr 27, 2018

Cherry pick of #62654 on release-1.9.

#62654: Ensure service routing resolves kubernetes.default.svc

Fixes the kubernetes.default.svc loopback service resolution to use a loopback configuration.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 27, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 27, 2018
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Apr 27, 2018

/retest

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented May 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2018
@ncdc
Copy link
Copy Markdown
Member

ncdc commented May 10, 2018

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from ncdc May 10, 2018 13:51
@mbohlool
Copy link
Copy Markdown
Contributor

why this is a cherrypick of a cherrypick?

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 10, 2018

because the 1.10 pick required manual fixup, and picked cleanly into 1.9

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 10, 2018

/retest

@mbohlool mbohlool added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 15, 2018
@mbohlool mbohlool removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 15, 2018
@mbohlool
Copy link
Copy Markdown
Contributor

I think you may need to add the release note to the parent PR.

@k8s-github-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit b6222f0 into kubernetes:release-1.9 May 15, 2018
@liggitt liggitt deleted the automated-cherry-pick-of-#62654-upstream-release-1.9 branch April 22, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants