Skip to content

Remove unneeded deps from vendor#62736

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
cblecker:remove-unneeded-deps
Apr 17, 2018
Merged

Remove unneeded deps from vendor#62736
k8s-github-robot merged 1 commit intokubernetes:masterfrom
cblecker:remove-unneeded-deps

Conversation

@cblecker
Copy link
Copy Markdown
Member

What this PR does / why we need it:
#58784 removed the initresource admission plugin, but didn't remove it's dependencies.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62696.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2018
@k8s-ci-robot k8s-ci-robot requested review from jbeda and lavalamp April 17, 2018 17:05
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2018
@cblecker
Copy link
Copy Markdown
Member Author

/assign @derekwaynecarr @BenTheElder

@cblecker
Copy link
Copy Markdown
Member Author

/test pull-kubernetes-e2e-gce

@ixdy
Copy link
Copy Markdown
Contributor

ixdy commented Apr 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2018
@cblecker
Copy link
Copy Markdown
Member Author

/retest

Copy link
Copy Markdown
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit cdba0ce into kubernetes:master Apr 17, 2018
@cblecker cblecker deleted the remove-unneeded-deps branch April 17, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test : [sig-testing] verify.godeps failing in sig-release-master-blocking

6 participants