Skip to content

Automated cherry pick of #61201: Prevent garbage collector from attempting to sync with 0 resources#61318

Merged
k8s-github-robot merged 3 commits intokubernetes:release-1.8from
jennybuckley:automated-cherry-pick-of-#61201-upstream-release-1.8
Mar 29, 2018
Merged

Automated cherry pick of #61201: Prevent garbage collector from attempting to sync with 0 resources#61318
k8s-github-robot merged 3 commits intokubernetes:release-1.8from
jennybuckley:automated-cherry-pick-of-#61201-upstream-release-1.8

Conversation

@jennybuckley
Copy link
Copy Markdown

@jennybuckley jennybuckley commented Mar 17, 2018 •
edited
Loading

Cherry pick of #61201 on release-1.8.

#61201: Prevent garbage collector from attempting to sync with 0 resources

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 17, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2018
@jennybuckley jennybuckley changed the title Automated cherry pick of #61201: Add unit test TestGarbageCollectorSync Automated cherry pick of #61201: Prevent garbage collector from attempting to sync with 0 resources Mar 17, 2018
@jennybuckley
Copy link
Copy Markdown
Author

jennybuckley commented Mar 19, 2018

/retest

@jennybuckley
Copy link
Copy Markdown
Author

jennybuckley commented Mar 19, 2018

/cc @jpbetz
/sig api-machinery

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz March 19, 2018 17:52
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 19, 2018
@jennybuckley
Copy link
Copy Markdown
Author

jennybuckley commented Mar 19, 2018

/retest

@k8s-ci-robot k8s-ci-robot reopened this Mar 19, 2018
@jennybuckley
Copy link
Copy Markdown
Author

jennybuckley commented Mar 19, 2018

/retest

@jennybuckley
Copy link
Copy Markdown
Author

jennybuckley commented Mar 20, 2018

/test pull-kubernetes-kubemark-e2e-gce

@jennybuckley
Copy link
Copy Markdown
Author

jennybuckley commented Mar 20, 2018

#61112

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 26, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jennybuckley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Mar 26, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@jennybuckley
Copy link
Copy Markdown
Author

jennybuckley commented Mar 26, 2018

I think this is good to go

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Mar 29, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Mar 29, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Mar 29, 2018

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit de98878 into kubernetes:release-1.8 Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@lavalamp lavalamp Awaiting requested review from lavalamp

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jennybuckley @k8s-ci-robot @fejta-bot @k8s-github-robot @jpbetz