Skip to content

Add //test/e2e/... and //test/integration/... to //build/visible_to:COMMON_testing#60669

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
ixdy:bazel-test-visibility
Mar 2, 2018
Merged

Add //test/e2e/... and //test/integration/... to //build/visible_to:COMMON_testing#60669
k8s-github-robot merged 1 commit intokubernetes:masterfrom
ixdy:bazel-test-visibility

Conversation

@ixdy
Copy link
Copy Markdown
Contributor

@ixdy ixdy commented Mar 1, 2018

What this PR does / why we need it: adds the common test packages //test/e2e/... and //test/integration/... to the COMMON_testing package group.

The immediate need for this is that #60580 unintentionally broke the integration tests under bazel since it added a new dependency on //pkg/kubectl/cmd/util without adding an appropriate entry to //build/visible_to:COMMON_testing, and the integration tests aren't currently run under bazel for PRs.

This PR fixes this breakage and proactively fixes future breakages by adding all packages under //test/e2e or //test/integration to COMMON_testing.

Release note:

NONE

/assign @BenTheElder @monopole
/kind bug
/priority important-soon
/sig testing
cc @kad

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 1, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2018
@k8s-ci-robot k8s-ci-robot requested review from jbeda and mikedanese March 1, 2018 22:33
@ixdy ixdy added this to the v1.10 milestone Mar 1, 2018
ixdy
ixdy commented Mar 1, 2018
View reviewed changes
build/visible_to/BUILD
"//test/integration/etcd",
"//test/integration/framework",
"//test/integration/kubectl",
"//test/e2e/...",
Copy link
Copy Markdown
Contributor Author

@ixdy ixdy Mar 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somewhat feel like //test/e2e shouldn't be allowed to depend on large swaths of the tree, but that's probably work for another day...

@kad
Copy link
Copy Markdown
Member

kad commented Mar 1, 2018

Works in my environment:

INFO: Analysed 6042 targets (48 packages loaded).
INFO: Found 6042 targets...
INFO: Elapsed time: 170.097s, Critical Path: 65.55s
INFO: Build completed successfully, 392 total actions

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2018
BenTheElder
BenTheElder approved these changes Mar 1, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy, kad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Mar 1, 2018

/retest

@ixdy
Copy link
Copy Markdown
Contributor Author

ixdy commented Mar 2, 2018

/assign @spiffxp @fejta @stevekuznetsov @timothysc

can one of you please approve for the v1.10 milestone? thanks!

@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Mar 2, 2018

/status approved-for-milestone

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 2, 2018

You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to add status labels.

@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Mar 2, 2018

/woof

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 2, 2018

@stevekuznetsov: dog image

Details

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Mar 2, 2018

@ixdy looks like no, I cannot

@cblecker
Copy link
Copy Markdown
Member

cblecker commented Mar 2, 2018

manually adding because @stevekuznetsov is a sig-testing lead

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Mar 2, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@BenTheElder @fejta @ixdy @kad @monopole @spiffxp @stevekuznetsov @timothysc

Pull Request Labels
  • sig/testing: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Mar 2, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Mar 2, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 79257fe into kubernetes:master Mar 2, 2018
@ixdy ixdy deleted the bazel-test-visibility branch May 15, 2018 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@jbeda jbeda Awaiting requested review from jbeda

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@kad kad

@spiffxp spiffxp

@timothysc timothysc

@BenTheElder BenTheElder

@fejta fejta

@monopole monopole

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.10

Development

Successfully merging this pull request may close these issues.