fix invalid admission name LimitPodHardAntiAffinityTopology#58595
Conversation
|
This change breaks backwards compatibility, I think: |
|
I referenced https://kubernetes.io/docs/admin/admission-controllers/#limitpodhardantiaffinity /lgtm And the document need revise. |
|
/test pull-kubernetes-e2e-kops-aws |
I think so! |
|
Which name does 1.9 use? |
|
@sttts |
|
/lgtm |
|
/test pull-kubernetes-e2e-kops-aws |
|
this is a widespread failure today. |
|
@CaoShuFeng Just remember The annotation also need revise. |
5890b53 to
2a15776
Compare
Done. |
|
/lgtm |
|
/test pull-kubernetes-e2e-kops-aws |
|
/approve no-issue |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CaoShuFeng, deads2k, hzxuzhonghu, sttts Associated issue requirement bypassed by: deads2k, sttts The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@CaoShuFeng: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 58595, 58689). If you want to cherry-pick this change to another branch, please follow the instructions here. |
@hzxuzhonghu
@sttts
Release note: