Skip to content

[WIP] get secret from CSI PV annotation and pass into user credential in NodePublishVolume#58527

Closed
rootfs wants to merge 1 commit into
kubernetes:masterfrom
rootfs:csi-cred
Closed

[WIP] get secret from CSI PV annotation and pass into user credential in NodePublishVolume#58527
rootfs wants to merge 1 commit into
kubernetes:masterfrom
rootfs:csi-cred

Conversation

@rootfs

@rootfs rootfs commented Jan 19, 2018

Copy link
Copy Markdown

What this PR does / why we need it:
Pass user credentials into NodePublishVolume. Volumes such like rbd need credentials to map images.

THIS IS a temporary solution for 1.9. Long term fix will be different from @sbezverk

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #58524

Special notes for your reviewer:
/sig storage
Release note:

NONE

get secret from CSI PV annotation and pass into user credential in No…
9893f62 
…dePublishVolume

Signed-off-by: Huamin Chen <hchen@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 19, 2018
@k8s-ci-robot

k8s-ci-robot commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootfs

Associated issue: #58524

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2018
@rootfs rootfs mentioned this pull request Jan 19, 2018
Closed
@k8s-ci-robot

k8s-ci-robot commented Jan 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

@rootfs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 9893f62 link /test pull-kubernetes-bazel-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rootfs

rootfs commented Jan 19, 2018

Copy link
Copy Markdown
Author

per http://blog.kubernetes.io/2018/01/introducing-container-storage-interface.html, credentials are not supported in alpha. Closing.

@rootfs rootfs closed this Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gnufied gnufied

@verult verult

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CSI Volume Plugin: Need to handle UserCredentials

4 participants

@rootfs @k8s-ci-robot @gnufied @verult