Skip to content

Cherry pick of #56503 on 1.8#56708

Merged
k8s-github-robot merged 1 commit intokubernetes:release-1.8from
php-coder:fail_non_root_verification_1.8
Dec 4, 2017
Merged

Cherry pick of #56503 on 1.8#56708
k8s-github-robot merged 1 commit intokubernetes:release-1.8from
php-coder:fail_non_root_verification_1.8

Conversation

@php-coder
Copy link
Copy Markdown
Contributor

@php-coder php-coder commented Dec 1, 2017 •
edited by jpbetz
Loading

What this PR does / why we need it:
Cherry pick of #56503 (MustRunAsNonRoot should reject a pod if it has non-numeric USER) on release-1.8

Release note:

kubelet: Fix bug where `runAsUser: MustRunAsNonRoot` strategy didn't reject a pod with a non-numeric `USER`.

CC @liggitt @tallclair @simo5

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 1, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: php-coder
We suggest the following additional approver: random-liu

Assign the PR to them by writing /assign @random-liu in a comment when ready.

Associated issue: 55004

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 1, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 1, 2017
@dashpole
Copy link
Copy Markdown
Contributor

dashpole commented Dec 1, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2017
@enisoc enisoc added this to the v1.8 milestone Dec 2, 2017
@enisoc enisoc added status/approved-for-milestone priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 2, 2017
@jpbetz jpbetz added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 4, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 4, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Dec 4, 2017

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 4, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 4, 2017

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@Random-Liu @dashpole @php-coder

Action required: This pull request requires label changes.

sig owner: Must specify at least one label prefixed with sig/.

Help

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 4, 2017

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 2c8f913 into kubernetes:release-1.8 Dec 4, 2017
@php-coder php-coder deleted the fail_non_root_verification_1.8 branch December 4, 2017 20:00
@KashifSaadat KashifSaadat mentioned this pull request Jun 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dashpole dashpole

@Random-Liu Random-Liu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

8 participants

@php-coder @k8s-github-robot @dashpole @liggitt @jpbetz @Random-Liu @enisoc @k8s-ci-robot