Automated cherry pick of #55259#56222
Merged
k8s-github-robot merged 1 commit intokubernetes:release-1.8from Nov 27, 2017
Merged
Automated cherry pick of #55259#56222k8s-github-robot merged 1 commit intokubernetes:release-1.8from
k8s-github-robot merged 1 commit intokubernetes:release-1.8from
Conversation
Allow the garbage collector to tolerate partial discovery failures. On a partial failure, use whatever was discovered, log the failures, and allow the resync logic to try again later. Fixes kubernetes#55022.
Member
Author
|
cc @jpbetz |
Contributor
|
/lgtm Who can approve this? @thockin this needs priority |
Member
|
/lgtm |
janetkuo
approved these changes
Nov 22, 2017
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chrislovecnm, janetkuo, justinsb Assign the PR to them by writing Associated issue: 55259 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Member
|
/assign @jpbetz would you cherrypick approve this patch? Thanks! |
|
[MILESTONENOTIFIER] Milestone Pull Request Current @chrislovecnm @erictune @janetkuo @jpbetz @justinsb Pull Request Labels
|
|
/test all Tests are more than 96 hours old. Re-running tests. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #55259 on release-1.8.
#55259: Tolerate partial discovery in garbage collector