Skip to content

pkg/controller/garbagecollector/garbagecollector.go: fix string format#56150

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
php-coder:fix_format_string
Dec 15, 2017
Merged

pkg/controller/garbagecollector/garbagecollector.go: fix string format#56150
k8s-github-robot merged 1 commit intokubernetes:masterfrom
php-coder:fix_format_string

Conversation

@php-coder
Copy link
Copy Markdown
Contributor

@php-coder php-coder commented Nov 21, 2017

What this PR does / why we need it:
This PR fixes broken formatting in the warning message by using appropriate function:

W1121 13:13:39.359283 19160 garbagecollector.go:601] failed to discover preferred resources: %vGet https://127.0.0.1:37983/api: dial tcp 127.0.0.1:37983: getsockopt: connection refused

Special notes for your reviewer:
This change was introduced in #55259

Release note:

NONE

PTAL @ironcladlou
CC @simo5

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2017
@php-coder php-coder mentioned this pull request Nov 21, 2017
Merged
@dhilipkumars
Copy link
Copy Markdown

dhilipkumars commented Nov 22, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 22, 2017
@ironcladlou
Copy link
Copy Markdown
Contributor

ironcladlou commented Nov 27, 2017

Good catch, thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2017
@php-coder
Copy link
Copy Markdown
Contributor Author

php-coder commented Nov 27, 2017

PTAL @deads2k

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Nov 27, 2017

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Nov 27, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ironcladlou, php-coder

Associated issue: 55259

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@php-coder
Copy link
Copy Markdown
Contributor Author

php-coder commented Nov 27, 2017

TestMixedRelationships is flaking. Looks like #56262

@php-coder
Copy link
Copy Markdown
Contributor Author

php-coder commented Nov 27, 2017

/test pull-kubernetes-unit

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Nov 30, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

2 similar comments
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Dec 2, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Dec 7, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 15, 2017

Automatic merge from submit-queue (batch tested with PRs 57211, 56150, 56368, 56271, 55957). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f588bb0 into kubernetes:master Dec 15, 2017
@php-coder php-coder deleted the fix_format_string branch December 15, 2017 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ironcladlou ironcladlou

@lavalamp lavalamp

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@php-coder @dhilipkumars @ironcladlou @deads2k @k8s-github-robot @fejta-bot @lavalamp @k8s-ci-robot