Skip to content

Update Gophercloud dependency for reauth problem#55657

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
dims:update-gophercloud-for-1.9
Nov 16, 2017
Merged

Update Gophercloud dependency for reauth problem#55657
k8s-github-robot merged 1 commit intokubernetes:masterfrom
dims:update-gophercloud-for-1.9

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Nov 14, 2017

What this PR does / why we need it:

Fixes picked up from gophercloud:
gophercloud/gophercloud@443743e...0b6b13c

Including the one for endless loop on reauth:
gophercloud/gophercloud#604

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #55656

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2017
@FengyunPan
Copy link
Copy Markdown

The verify-staging-godeps.sh is broken.

@dims dims force-pushed the update-gophercloud-for-1.9 branch 4 times, most recently from 859d883 to 8fd8b2b Compare November 14, 2017 13:51
@dims dims closed this Nov 14, 2017
@dims dims force-pushed the update-gophercloud-for-1.9 branch from 8fd8b2b to 48d0627 Compare November 14, 2017 14:04
@dims dims reopened this Nov 14, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2017
@dims
Copy link
Copy Markdown
Member Author

dims commented Nov 14, 2017

/test pull-kubernetes-cross

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 14, 2017

@dims: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 709eee068e2ff4fb7c5aa459959748c4b8f05395 link /test pull-kubernetes-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Fixes picked up from gophercloud are:
gophercloud/gophercloud@443743e...0b6b13c

Including the one for endless loop on reauth:
gophercloud/gophercloud#604
@dims dims force-pushed the update-gophercloud-for-1.9 branch from 709eee0 to 4366454 Compare November 14, 2017 14:25
@dims
Copy link
Copy Markdown
Member Author

dims commented Nov 14, 2017

@FengyunPan it's almost ready now (past the verify problem)

@idvoretskyi
Copy link
Copy Markdown
Member

/approve

@dims
Copy link
Copy Markdown
Member Author

dims commented Nov 14, 2017

Thanks @idvoretskyi

/assign @thockin

@thockin
Copy link
Copy Markdown
Member

thockin commented Nov 14, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2017
@FengyunPan
Copy link
Copy Markdown

/lgtm

@k8s-github-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, FengyunPan, idvoretskyi, thockin

Associated issue: 55656

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue (batch tested with PRs 55657, 54758, 47584, 55758, 55651). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0865965 into kubernetes:master Nov 16, 2017
@dims dims deleted the update-gophercloud-for-1.9 branch November 16, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Endless recursive requests to server when server response error

8 participants