Skip to content

kubeadm mount path '/lib/modules'#55130

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
Lion-Wei:kubeadm-modprobe
Nov 7, 2017
Merged

kubeadm mount path '/lib/modules'#55130
k8s-github-robot merged 1 commit intokubernetes:masterfrom
Lion-Wei:kubeadm-modprobe

Conversation

@Lion-Wei
Copy link
Copy Markdown

@Lion-Wei Lion-Wei commented Nov 6, 2017

What this PR does / why we need it:
Kube-proxy need mount path '/lib/modules' to load kernel modules automatically inside the pod.

We already have this pr: #52003, for 'cluster/addons' and `saltbase'.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 6, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Lion-Wei. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2017
@Lion-Wei
Copy link
Copy Markdown
Author

Lion-Wei commented Nov 6, 2017

/cc @MrHohn @thockin @m1093782566

@m1093782566
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2017
@m1093782566
Copy link
Copy Markdown
Contributor

/cc @luxas

@k8s-ci-robot k8s-ci-robot requested a review from luxas November 6, 2017 03:21
@Lion-Wei
Copy link
Copy Markdown
Author

Lion-Wei commented Nov 6, 2017

/test pull-kubernetes-unit

@thockin
Copy link
Copy Markdown
Member

thockin commented Nov 7, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2017
@k8s-github-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lion-Wei, thockin

Associated issue: 52003

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2017
@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue (batch tested with PRs 53866, 54852, 55178, 55185, 55130). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 9feabbd into kubernetes:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants