Skip to content

Cronjob beta defaults#52533

Merged
k8s-github-robot merged 2 commits intokubernetes:masterfrom
soltysh:cronjob_beta_defaults
Sep 20, 2017
Merged

Cronjob beta defaults#52533
k8s-github-robot merged 2 commits intokubernetes:masterfrom
soltysh:cronjob_beta_defaults

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented Sep 15, 2017

What this PR does / why we need it:
I forget to set the defaults in beta for (successful|failed)JobsHistoryLimit so doing this now. It's already too late for 1.8 so this goes into 1.9.

Release note:

Set defaults for successfulJobsHistoryLimit (3) and failedJobsHistoryLimit (1) in batch/v1beta1.CronJobs

@soltysh soltysh added this to the v1.9 milestone Sep 15, 2017
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2017
@soltysh soltysh added area/batch area/workload-api/cronjob sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Sep 15, 2017
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 15, 2017
@soltysh soltysh force-pushed the cronjob_beta_defaults branch from 75a56cf to eade908 Compare September 15, 2017 12:57
janetkuo
janetkuo suggested changes Sep 19, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default values cannot be changed in the same API version. This PR should either target 1.8 or wait for the next API version.

@janetkuo janetkuo modified the milestones: v1.9, v1.8 Sep 19, 2017
@dims
Copy link
Copy Markdown
Member

dims commented Sep 19, 2017

@soltysh should we remove the 1.9 milestone then?

@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Sep 19, 2017

@janetkuo I'm not sure we're able to get this in for 1.8, or do we?

/retest

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Sep 19, 2017

This seems fairly important, and API changes are the most critical thing to get right before we ship. Let's get the release team involved

janetkuo
janetkuo approved these changes Sep 19, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM

@janetkuo
Copy link
Copy Markdown
Member

janetkuo commented Sep 19, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2017
@janetkuo
Copy link
Copy Markdown
Member

janetkuo commented Sep 19, 2017

cc @erictune @kow3ns

@janetkuo
Copy link
Copy Markdown
Member

janetkuo commented Sep 19, 2017

@soltysh we should request an exception

@janetkuo
Copy link
Copy Markdown
Member

janetkuo commented Sep 19, 2017

cc @jdumars (1.8 release team lead)

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Sep 19, 2017

This has API approval for 1.8 because we cannot change this post ship.

@kow3ns
Copy link
Copy Markdown
Member

kow3ns commented Sep 19, 2017

We need to ship this in 1.8 as break fix. Correct defaults is not a feature. Incorrect defaults is a bug.

@kow3ns
Copy link
Copy Markdown
Member

kow3ns commented Sep 19, 2017

@jdumars @michelleN @kubernetes/sig-release-api-reviews @kubernetes/sig-release-bugs we need an exception for this so we can release it in 1.8.

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. labels Sep 19, 2017
@jdumars
Copy link
Copy Markdown
Contributor

jdumars commented Sep 19, 2017

This has already been added to the 1.8 milestone, and looks like it just needs approval to move forward.

@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Sep 19, 2017

/retest

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Sep 19, 2017

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2017
@erictune
Copy link
Copy Markdown
Contributor

erictune commented Sep 20, 2017

/approve

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 20, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erictune, janetkuo, smarterclayton, soltysh

Associated issue requirement bypassed by: smarterclayton

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@janetkuo
Copy link
Copy Markdown
Member

janetkuo commented Sep 20, 2017

/test pull-kubernetes-unit

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 20, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 20, 2017

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 eade908 link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 20, 2017

Automatic merge from submit-queue (batch tested with PRs 52500, 52533). If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit 9a7818a into kubernetes:master Sep 20, 2017
@soltysh soltysh deleted the cronjob_beta_defaults branch September 20, 2017 09:38
@soltysh soltysh mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@janetkuo janetkuo janetkuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@janetkuo janetkuo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/batch area/workload-api/cronjob cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

9 participants

@soltysh @dims @smarterclayton @janetkuo @kow3ns @jdumars @erictune @k8s-github-robot @k8s-ci-robot