Skip to content

Bugfix: Fix e2e Flaky Apps/Job BackoffLimit test#52476

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
clamoriniere1A:bugfix/e2e_job_backoff_flaky
Sep 15, 2017
Merged

Bugfix: Fix e2e Flaky Apps/Job BackoffLimit test#52476
k8s-github-robot merged 1 commit intokubernetes:masterfrom
clamoriniere1A:bugfix/e2e_job_backoff_flaky

Conversation

@clamoriniere1A
Copy link
Copy Markdown
Contributor

@clamoriniere1A clamoriniere1A commented Sep 14, 2017

This fix is linked to the PR #51153 that introduce the JobSpec.BackoffLimit.

Previously the Timeout used in the test was too aggressive and generates flaky test execution. Now it used the default framework.JobTimeout used in others tests.

What this PR does / why we need it:
This PR should fix flaky "[sig-apps] Job should exceed backoffLimit" test, due to a too short timeout duration.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #51153

Special notes for your reviewer:

Release note:

@clamoriniere1A
Fix e2e Flaky Apps/Job BackoffLimit test
0d7182f 
This fix is linked to the PR kubernetes#51153 that introduce the
JobSpec.BackoffLimit.
Previously the Timeout used in the test was too agressive and generates
flaky test execution. Now it used the default framework.JobTimeout used
in others tests.
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 14, 2017

Hi @clamoriniere1A. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 14, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 14, 2017
@clamoriniere1A
Copy link
Copy Markdown
Contributor Author

clamoriniere1A commented Sep 14, 2017

/assign @soltysh

@xiangpengzhao
Copy link
Copy Markdown
Contributor

xiangpengzhao commented Sep 14, 2017

/release-note-none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 14, 2017
@clamoriniere1A
Copy link
Copy Markdown
Contributor Author

clamoriniere1A commented Sep 14, 2017

/test pull-kubernetes-e2e-gce-bazel

@soltysh soltysh added this to the v1.8 milestone Sep 14, 2017
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Sep 14, 2017

/retest
/lgtm
/approve

I'm applying 1.8 milestone since this is fixing a flake.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 14, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clamoriniere1A, soltysh

Associated issue: 51153

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2017
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 15, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 15, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@xiangpengzhao
Copy link
Copy Markdown
Contributor

xiangpengzhao commented Sep 15, 2017

/retest

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 15, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 15, 2017 •
edited
Loading

@clamoriniere1A: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel 0d7182f link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 15, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 87a1b5f into kubernetes:master Sep 15, 2017
@clamoriniere1A clamoriniere1A deleted the bugfix/e2e_job_backoff_flaky branch September 15, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@soltysh soltysh

@foxish foxish

@enisoc enisoc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

8 participants

@clamoriniere1A @k8s-ci-robot @xiangpengzhao @soltysh @k8s-github-robot @fejta-bot @foxish @enisoc