Skip to content

Add ReclaimPolicy field to kubectl describe storageclass output.#51607

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
xingzhou:sc-newfield
Sep 23, 2017
Merged

Add ReclaimPolicy field to kubectl describe storageclass output.#51607
k8s-github-robot merged 1 commit intokubernetes:masterfrom
xingzhou:sc-newfield

Conversation

@xingzhou
Copy link
Copy Markdown
Contributor

@xingzhou xingzhou commented Aug 30, 2017

Add ReclaimPolicy field to kubectl describe storageclass output.

PR #47987 added ReclaimPolicy field to StorageClass.

Release note:

None

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 30, 2017

Hi @xingzhou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 30, 2017
@sttts sttts assigned fabianofranz and unassigned sttts and smarterclayton Aug 31, 2017
xiangpengzhao
xiangpengzhao suggested changes Sep 4, 2017
View reviewed changes
pkg/printers/internalversion/describe.go Outdated
w.Write(LEVEL_0, "Annotations:\t%s\n", labels.FormatLabels(sc.Annotations))
w.Write(LEVEL_0, "Provisioner:\t%s\n", sc.Provisioner)
w.Write(LEVEL_0, "Parameters:\t%s\n", labels.FormatLabels(sc.Parameters))
w.Write(LEVEL_0, "ReclaimPolicy:\t%s\n", *sc.ReclaimPolicy)
Copy link
Copy Markdown
Contributor

@xiangpengzhao xiangpengzhao Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check if ReclaimPolicy is nil before printing it :)

Copy link
Copy Markdown
Contributor Author

@xingzhou xingzhou Sep 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review, have updated the code.

@xiangpengzhao
Copy link
Copy Markdown
Contributor

xiangpengzhao commented Sep 4, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2017
@xingzhou
Add ReclaimPolicy field to kubectl describe storageclass output.
957cc8f 
Add `ReclaimPolicy` field to `kubectl describe storageclass` output.
@fabianofranz
Copy link
Copy Markdown
Contributor

fabianofranz commented Sep 8, 2017

/test pull-kubernetes-e2e-kops-aws

@fabianofranz
Copy link
Copy Markdown
Contributor

fabianofranz commented Sep 8, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 8, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, xingzhou

Associated issue requirement bypassed by: fabianofranz

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2017
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 11, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

2 similar comments
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 11, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 12, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fabianofranz
Copy link
Copy Markdown
Contributor

fabianofranz commented Sep 15, 2017

/test pull-kubernetes-e2e-gce-bazel

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 16, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 20, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 23, 2017

Automatic merge from submit-queue (batch tested with PRs 51438, 52182, 51607, 47912, 51595). If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit 8064930 into kubernetes:master Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xiangpengzhao xiangpengzhao xiangpengzhao requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fabianofranz fabianofranz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@xingzhou @k8s-ci-robot @xiangpengzhao @fabianofranz @k8s-github-robot @fejta-bot @sttts @smarterclayton