Skip to content

Automated cherry pick of #50098#50250

Merged
k8s-github-robot merged 1 commit intokubernetes:release-1.7from
nikhita:automated-cherry-pick-of-#50098-upstream-release-1.7
Aug 7, 2017
Merged

Automated cherry pick of #50098#50250
k8s-github-robot merged 1 commit intokubernetes:release-1.7from
nikhita:automated-cherry-pick-of-#50098-upstream-release-1.7

Conversation

@nikhita
Copy link
Copy Markdown
Member

@nikhita nikhita commented Aug 7, 2017

Cherry pick of #50098 on release-1.7.

#50098: fix data race in storage (during addition)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 7, 2017

Hi @nikhita. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 7, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2017
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

cc @sttts
/assign @wojtek-t

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 7, 2017
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Aug 7, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2017
@k8s-github-robot k8s-github-robot added this to the v1.7 milestone Aug 7, 2017
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

/retest

@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

@sttts approved?

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Aug 7, 2017

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2017
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

@sttts @deads2k this needs a lgtm too :)

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Aug 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 7, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, nikhita, sttts

Associated issue: 50098

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

/retest

@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

/test pull-kubernetes-e2e-gce-etcd3

@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

/retest

@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

/test pull-kubernetes-verify

@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Aug 7, 2017

/test pull-kubernetes-e2e-gce-etcd3

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 7, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 7, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 4d5c823 into kubernetes:release-1.7 Aug 7, 2017
@nikhita nikhita deleted the automated-cherry-pick-of-#50098-upstream-release-1.7 branch August 7, 2017 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sttts sttts

@enisoc enisoc

@deads2k deads2k

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

7 participants

@nikhita @k8s-ci-robot @wojtek-t @deads2k @sttts @k8s-github-robot @enisoc