Add a refreshing discovery client#48502
Merged
k8s-github-robot merged 2 commits intokubernetes:masterfrom Jul 5, 2017
Merged
Conversation
37196b8 to
2639b75
Compare
Contributor
Author
|
/test pull-kubernetes-unit |
Contributor
|
/retest |
Contributor
|
/lgtm |
Contributor
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ironcladlou Associated issue requirement bypassed by: deads2k The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
Author
|
Tests are flaking on #48368 |
Contributor
Author
|
/test pull-kubernetes-unit |
|
Automatic merge from submit-queue (batch tested with PRs 47700, 48464, 48502) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a discovery client (implementing
CachedDiscoveryInterface) which caches discovery information in memory and which can be actively refreshed by the user.This implementation fetches from discovery upon refresh and could later be improved to maintain updates from a watch.
Extracted from #47665 and #46000 to help reduce the scope of #48065.