Skip to content

Add test for kube-proxy running with "--cleanup-iptables=true"#48237

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
xiangpengzhao:fix-proxy-test
Aug 4, 2017
Merged

Add test for kube-proxy running with "--cleanup-iptables=true"#48237
k8s-github-robot merged 1 commit intokubernetes:masterfrom
xiangpengzhao:fix-proxy-test

Conversation

@xiangpengzhao
Copy link
Copy Markdown
Contributor

@xiangpengzhao xiangpengzhao commented Jun 29, 2017

What this PR does / why we need it:
Add test to prevent such kube-proxy panic to happen again.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #48177

Special notes for your reviewer:
Forgot to add this in last PR #48183. Should we also add this to v1.7 milestone?
/cc @ncdc @dchen1107

Release note:

NONE

@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and ncdc June 29, 2017 02:29
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 29, 2017

Hi @xiangpengzhao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 29, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 29, 2017
@ncdc
Copy link
Copy Markdown
Member

ncdc commented Jun 29, 2017

/ok-to-test
/test all

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 29, 2017
@ncdc
Copy link
Copy Markdown
Member

ncdc commented Jun 29, 2017

/assign

@ncdc
Copy link
Copy Markdown
Member

ncdc commented Jun 29, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2017
@ncdc
Copy link
Copy Markdown
Member

ncdc commented Jun 29, 2017

/unassign @lavalamp @thockin
/assign @dchen1107

@k8s-ci-robot k8s-ci-robot assigned dchen1107 and unassigned lavalamp and thockin Jun 29, 2017
@xiangpengzhao xiangpengzhao mentioned this pull request Jul 17, 2017
Closed
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2017
@xiangpengzhao
Copy link
Copy Markdown
Contributor Author

xiangpengzhao commented Jul 17, 2017

@dchen1107 @ncdc PTAL, thanks!

@ncdc
Copy link
Copy Markdown
Member

ncdc commented Jul 17, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2017
@xiangpengzhao xiangpengzhao mentioned this pull request Jul 19, 2017
Closed
@xiangpengzhao
Copy link
Copy Markdown
Contributor Author

xiangpengzhao commented Jul 26, 2017

/retest

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Jul 27, 2017

/lgtm

@cmluciano
Copy link
Copy Markdown

cmluciano commented Jul 31, 2017

/assign @thockin

for cmd/ review

@thockin
Copy link
Copy Markdown
Member

thockin commented Aug 4, 2017

/approve

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 4, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, ncdc, thockin, xiangpengzhao

Associated issue: 48177

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 4, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0c2f816 into kubernetes:master Aug 4, 2017
@xiangpengzhao xiangpengzhao deleted the fix-proxy-test branch August 4, 2017 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@ncdc ncdc

@thockin thockin

@dchen1107 dchen1107

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hyperkube kube-proxy panics when run with '--cleanup-iptables=true' starting with v1.7.0-alpha.3

9 participants

@xiangpengzhao @k8s-ci-robot @ncdc @dcbw @cmluciano @thockin @k8s-github-robot @lavalamp @dchen1107