Skip to content

Admissionregistration nonnamespace#46668

Merged
k8s-github-robot merged 2 commits intokubernetes:masterfrom
caesarxuchao:admissionregistration-nonnamespace
Jun 2, 2017
Merged

Admissionregistration nonnamespace#46668
k8s-github-robot merged 2 commits intokubernetes:masterfrom
caesarxuchao:admissionregistration-nonnamespace

Conversation

@caesarxuchao
Copy link
Copy Markdown
Contributor

@caesarxuchao caesarxuchao commented May 31, 2017 •
edited
Loading

The two types are root scoped.

Just adding a couple of tags. Other code is generated.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2017
@caesarxuchao caesarxuchao added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. labels May 31, 2017
@caesarxuchao caesarxuchao mentioned this pull request May 31, 2017
Merged
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 31, 2017
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented May 31, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented May 31, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, smarterclayton

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2017
@caesarxuchao caesarxuchao force-pushed the admissionregistration-nonnamespace branch from 422b83d to ec787db Compare May 31, 2017 16:57
@caesarxuchao caesarxuchao added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@caesarxuchao
Copy link
Copy Markdown
Contributor Author

caesarxuchao commented May 31, 2017

Updated bazel.

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented May 31, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

3 similar comments
@caesarxuchao
Copy link
Copy Markdown
Contributor Author

caesarxuchao commented May 31, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@caesarxuchao
Copy link
Copy Markdown
Contributor Author

caesarxuchao commented May 31, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Jun 1, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@smarterclayton smarterclayton added this to the v1.7 milestone Jun 1, 2017
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Jun 2, 2017

Hrm, the bot forgot about this.

@smarterclayton smarterclayton mentioned this pull request Jun 2, 2017
Merged
@caesarxuchao
Copy link
Copy Markdown
Contributor Author

caesarxuchao commented Jun 2, 2017

@k8s-bot pull-kubernetes-verify test this

@caesarxuchao
Copy link
Copy Markdown
Contributor Author

caesarxuchao commented Jun 2, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jun 2, 2017

Automatic merge from submit-queue (batch tested with PRs 46648, 46500, 46238, 46668, 46557)

@k8s-github-robot k8s-github-robot merged commit 97ac6e7 into kubernetes:master Jun 2, 2017
@caesarxuchao caesarxuchao deleted the admissionregistration-nonnamespace branch May 12, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

4 participants

@caesarxuchao @smarterclayton @k8s-github-robot @k8s-ci-robot