Fix initializer_manager_test.go flake#46648
Fix initializer_manager_test.go flake#46648k8s-github-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
/release-note-none |
There was a problem hiding this comment.
This is not a good way to fix a flake. Maybe instead of letting the manager run, just call its sync method or whatever manually.
|
/lgtm Thanks, much better! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, lavalamp DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this |
|
i'll add a priority label since it's fixing a flaky test. |
|
@foxish do you know what priority label i should put on this flake fixing PR to let submit queue merge it quicker? |
|
@kubernetes/sig-testing-bugs did we drop the priority for flakes that are blocking the queue for it to move to the top of the queue? This issue caused the last batch to flake, but we don't how to bump it. |
|
@kubernetes/kubernetes-build-cops ^^^ |
|
Added queue/critical-fix to bump this up. Description of each label is in https://submit-queue.k8s.io/#/info |
|
Thanks, I never saw an update to the mar 21 discussion that said the old
labels don't work. Do you mind reminding folks of this on kubernetes-dev?
…On Fri, Jun 2, 2017 at 4:46 PM, Anirudh Ramanathan ***@***.*** > wrote:
Added queue/critical-fix to bump this up. Description of each label is in
https://submit-queue.k8s.io/#/info
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#46648 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p4xEB2IOqXU5t7fHdNHXTiqx1Mz0ks5sAHSdgaJpZM4Nq2dH>
.
|
|
Automatic merge from submit-queue (batch tested with PRs 46648, 46500, 46238, 46668, 46557) |
Fixes #46631.
I reproduced the flake after 98 runs.
With the fix, it's not flaky in 1000 runs.