Critial pod test uses allocatable instead of capacity#42341
Merged
Conversation
Contributor
Author
|
/release-note-none |
Contributor
Author
|
@k8s-bot unit test this |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: dashpole, vishh Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
|
lgtm |
1 similar comment
Member
|
lgtm |
Contributor
Author
|
@k8s-bot gci gce e2e test this |
|
This change is |
Contributor
Author
|
@k8s-bot verify test this |
|
Automatic merge from submit-queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #42239.
When this test was first introduced, pods could request up to the capacity of the node.
With the addition of allocatable introduced in #41234, this is no longer the case, and pods can only use up to allocatable.
This should be included in 1.6, as it is a bug related to a 1.6 feature.
cc @vish @yujuhong