Skip to content

lengthen pod deletion timeout to prevent flakes#41157

Merged
jessfraz merged 1 commit into
kubernetes:masterfrom
dashpole:test_timeout_delete
Feb 9, 2017
Merged

lengthen pod deletion timeout to prevent flakes#41157
jessfraz merged 1 commit into
kubernetes:masterfrom
dashpole:test_timeout_delete

Conversation

@dashpole

@dashpole dashpole commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

#41095 may have increased deletion latency. Adjust timeouts to compensate.

@vishh @Random-Liu

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2017
@k8s-reviewable

k8s-reviewable commented Feb 8, 2017

Copy link
Copy Markdown

This change is Reviewable

@k8s-github-robot

k8s-github-robot commented Feb 8, 2017

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: dashpole

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @mikedanese
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Feb 8, 2017
@vishh

vishh commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

@vishh: you can't LGTM a PR unless you are an assignee.

Details

In response to this comment:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vishh vishh assigned vishh and unassigned sttts Feb 8, 2017
@vishh

vishh commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 8, 2017
@vishh vishh added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Feb 8, 2017
@dashpole

dashpole commented Feb 8, 2017

Copy link
Copy Markdown
Contributor Author

@k8s-bot kops aws e2e test this

@k8s-ci-robot

k8s-ci-robot commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

@dashpole: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins kops AWS e2e ab2ce9c link @k8s-bot kops aws e2e test this
Jenkins GCE etcd3 e2e ab2ce9c link @k8s-bot gce etcd3 e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dashpole

dashpole commented Feb 8, 2017

Copy link
Copy Markdown
Contributor Author

@k8s-bot gce etcd3 e2e test this

@ncdc ncdc mentioned this pull request Feb 9, 2017
Merged
@ncdc

ncdc commented Feb 9, 2017

Copy link
Copy Markdown
Member

@jessfraz @k8s-oncall you might want to up the priority on this to try to help eliminate flakes & queue blockage

@jessfraz jessfraz merged commit 46becf2 into kubernetes:master Feb 9, 2017
@jessfraz

jessfraz commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

merged sorry!

@jessfraz

jessfraz commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

hopefully this unblocks

@ncdc

ncdc commented Feb 9, 2017

Copy link
Copy Markdown
Member

It should help for part of it, but not all (deployment, statefulset still have flakes)

@dashpole dashpole deleted the test_timeout_delete branch February 9, 2017 02:04
@dashpole dashpole mentioned this pull request Mar 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vishh vishh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dashpole @k8s-reviewable @k8s-github-robot @vishh @k8s-ci-robot @ncdc @jessfraz @sttts