delete cadvisor pod after test#40934
Merged
k8s-github-robot merged 1 commit intoFeb 15, 2017
Merged
Conversation
|
This change is |
Contributor
|
/approve |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED The following people have approved this PR: dashpole, yifan-gu Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
Contributor
|
Actually reassign to @vishh for the final call. |
Contributor
|
/approved |
Contributor
|
/lgtm |
|
Automatic merge from submit-queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracing looks at events for pod deletion and volume teardown. SInce the cadvisor pod has more than 1 volume, this can make results harder to analyze.
This PR moves the deletion of the cadvisor pod to after the logPodCreateThroughput call, since that marks the "end" of the test.
cc: @dchen1107 @Random-Liu