Skip to content

kubelet: fix nil deref in volume type check#39529

Merged
k8s-github-robot merged 1 commit into
kubernetes:release-1.5from
sjenning:fix-nil-deref-1.5
Jan 11, 2017
Merged

kubelet: fix nil deref in volume type check#39529
k8s-github-robot merged 1 commit into
kubernetes:release-1.5from
sjenning:fix-nil-deref-1.5

Conversation

@sjenning

@sjenning sjenning commented Jan 6, 2017

Copy link
Copy Markdown
Contributor

Cherry pick #39493

@saad-ali @derekwaynecarr @grosskur @gnufied

fix nil dereference when doing a volume type check on persistent volumes

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2017
@k8s-reviewable

k8s-reviewable commented Jan 6, 2017

Copy link
Copy Markdown

This change is Reviewable

@sjenning sjenning changed the title fix nil deref kubelet: fix nil deref in volume type check Jan 6, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 6, 2017
@gnufied

gnufied commented Jan 6, 2017

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Jan 6, 2017

Copy link
Copy Markdown
Contributor

@gnufied: you can't LGTM a PR unless you are an assignee.

Details

In response to this comment:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sjenning

sjenning commented Jan 6, 2017

Copy link
Copy Markdown
Contributor Author

@k8s-bot node e2e test this
@k8s-bot cri node e2e test this

@saad-ali saad-ali added this to the v1.5 milestone Jan 6, 2017
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jan 6, 2017
@saad-ali

saad-ali commented Jan 6, 2017

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2017
@saad-ali

saad-ali commented Jan 7, 2017

Copy link
Copy Markdown
Member

@k8s-bot cri node e2e test this

@saad-ali

saad-ali commented Jan 7, 2017

Copy link
Copy Markdown
Member

@k8s-bot node e2e test this

@sjenning

sjenning commented Jan 9, 2017

Copy link
Copy Markdown
Contributor Author

@k8s-bot node e2e test this
@k8s-bot cri node e2e test this

@k8s-ci-robot

k8s-ci-robot commented Jan 9, 2017

Copy link
Copy Markdown
Contributor

Jenkins CRI GCE Node e2e failed for commit 23378a8. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sjenning

sjenning commented Jan 9, 2017

Copy link
Copy Markdown
Contributor Author

@saad-ali something is up with the test infra for 1.5. cri node e2e and node e2e are getting ssh key errors it would seem.

@saad-ali

saad-ali commented Jan 10, 2017

Copy link
Copy Markdown
Member

Failing E2Es hit #39597 which is now fixed. Rerunning

@saad-ali

saad-ali commented Jan 10, 2017

Copy link
Copy Markdown
Member

@k8s-bot cri node e2e test this

@saad-ali

saad-ali commented Jan 10, 2017

Copy link
Copy Markdown
Member

@k8s-bot node e2e test this

@k8s-ci-robot

k8s-ci-robot commented Jan 10, 2017

Copy link
Copy Markdown
Contributor

Jenkins GCE Node e2e failed for commit 23378a8. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saad-ali

saad-ali commented Jan 10, 2017

Copy link
Copy Markdown
Member

@k8s-bot node e2e test this

@k8s-github-robot

k8s-github-robot commented Jan 11, 2017

Copy link
Copy Markdown

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

k8s-github-robot commented Jan 11, 2017

Copy link
Copy Markdown

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 12b2a7e into kubernetes:release-1.5 Jan 11, 2017
@sjenning sjenning deleted the fix-nil-deref-1.5 branch August 16, 2017 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@saad-ali saad-ali

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.

6 participants

@sjenning @k8s-reviewable @gnufied @k8s-ci-robot @saad-ali @k8s-github-robot